From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "Mark M. Hoffman" <mhoffman@lightlink.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
lm-sensors <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH 2/2] ibmaem: New driver for power/energy meters in IBM System X hardware
Date: Thu, 24 Apr 2008 15:16:46 -0700 [thread overview]
Message-ID: <20080424221645.GA16404@tree.beaverton.ibm.com> (raw)
In-Reply-To: <47F1A675.3050204@codemonkey.ws>
On Mon, Mar 31, 2008 at 10:05:25PM -0500, Anthony Liguori wrote:
> It really shouldn't be necessary to have all of these macro functions.
> In this above macro, you would just have to pass the ro and rw
> structures along with a remove function pointer. Since all of your
> types have common members, you could just have a common substructure and
> pass that around.
Hmm... it isn't too difficult to refactor the registration function to
make it easier to look at, though I'd rather keep the AEM1 and AEM2 guts
separate rather than aggressively eliminating macros by making the AEM1
structs a subset of the AEM2 structs.
--D
next prev parent reply other threads:[~2008-04-24 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 21:38 Darrick J. Wong
2008-04-01 3:05 ` Anthony Liguori
2008-04-24 22:16 ` Darrick J. Wong [this message]
2008-04-24 22:23 ` [PATCH v2] " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424221645.GA16404@tree.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome