From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: linux-pci@atrey.karlin.mff.cuni.cz, yhlu.kernel@gmail.com
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Ingo Molnar" <mingo@elte.hu>,
"David Miller" <davem@davemloft.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
tglx@linutronix.de, "Greg KH" <greg@kroah.com>,
"Jeff Garzik" <jeff@garzik.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Sathya Prakash <sathya.prakash@lsi.com>
Subject: Re: [PATCH 1/2] pci/irq: restore mask_bits in msi shutdown -v3
Date: Fri, 25 Apr 2008 14:48:21 -0700 [thread overview]
Message-ID: <200804251448.21966.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <200804231456.30786.yhlu.kernel@gmail.com>
On Wednesday, April 23, 2008 2:56 pm Yinghai Lu wrote:
> Yinghai found after using 2.6.25-rc3 later to kexec RHEL 5.1,
> NIC can not be used.
>
> bisected to
Hi Yinghai, I've been thinking about these patches a bit... They seem like an
important bug fix (making sure kexec'd kernels work), but I'm a bit worried
that the kexec'd kernel can't handle potentially broken MSI/INTx setups.
Shouldn't the kexec'd kernel be a bit more robust? I guess in this case
you're kexec'ing an old kernel, so there's not much we can do, but it still
makes me a little uneasy.
I guess for this particular set it doesn't matter much, since we should be
restoring things in pci_msi*_shutdown and pci_shutdown_device either way.
Can you clean up the changelog a bit and maybe make it more concise? E.g. we
probably don't need the whole commit message for the bisect, and we want to
be clearer about what the failure mode is w/o the changes...
Thanks,
Jesse
next prev parent reply other threads:[~2008-04-25 21:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 4:48 [PATCH] pci: let pci_device_shutdown to call pci_disable_msi Yinghai Lu
2008-04-23 5:24 ` Michael Ellerman
2008-04-23 6:08 ` Yinghai Lu
2008-04-23 13:08 ` Eric W. Biederman
2008-04-23 17:31 ` Yinghai Lu
2008-04-24 0:17 ` Michael Ellerman
2008-04-24 1:22 ` Yinghai Lu
2008-04-24 2:11 ` Yinghai Lu
2008-04-23 12:57 ` Eric W. Biederman
2008-04-23 17:32 ` Yinghai Lu
2008-04-23 21:56 ` [PATCH 1/2] pci/irq: restore mask_bits in msi shutdown -v3 Yinghai Lu
2008-04-23 21:58 ` [PATCH 2/2] pci/irq: let pci_device_shutdown to call pci_msi_shutdown v2 Yinghai Lu
2008-04-25 0:40 ` [PATCH 1/2] pci/irq: restore mask_bits in msi shutdown -v3 Yinghai Lu
2008-04-25 21:48 ` Jesse Barnes [this message]
2008-04-25 22:08 ` Yinghai Lu
2008-04-29 16:13 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804251448.21966.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=mingo@elte.hu \
--cc=sathya.prakash@lsi.com \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome