From: Randy Dunlap <randy.dunlap@oracle.com>
To: Matt LaPlante <kernel1@cyberdogtech.com>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] 2.6.25-git7 - Kconfig Cleanup
Date: Sat, 26 Apr 2008 09:16:52 -0700 [thread overview]
Message-ID: <20080426091652.19503700.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20080426011733.04dedb05.kernel1@cyberdogtech.com>
On Sat, 26 Apr 2008 01:17:33 -0500 Matt LaPlante wrote:
> On Fri, 25 Apr 2008 21:50:37 -0700
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
> > On Fri, 25 Apr 2008 23:28:48 -0500 Matt LaPlante wrote:
> >
> > > Fix misc small typos/grammar in Kconfigs for 2.6.25-git7.
> > >
> > > Signed-off-by: Matt LaPlante <kernel1@cyberdogtech.com>
> > > --
> > >
> > > diff -ru a/arch/cris/arch-v32/Kconfig b/arch/cris/arch-v32/Kconfig
> > > --- a/arch/cris/arch-v32/Kconfig 2008-04-16 21:49:44.000000000 -0500
> > > +++ b/arch/cris/arch-v32/Kconfig 2008-04-25 22:13:14.000000000 -0500
> > > @@ -27,8 +27,8 @@
> > > bool "Use one LED group"
> > > help
> > > Select this if you want one Ethernet LED group. This LED group
> > > - can be used for one or more Ethernet interfaces. However, it is
> > > - recomended that each Ethernet interface use a dedicated LED group.
> > > + can be used for one or more Ethernet interfaces, however it is
> >
> > That comma creates a run-on sentence. Period was better.
>
> My problem is the second sentence starting with "however." Although it's not technically breaking any rules, writing style guides generally advise against beginning sentences with it... and on a more basic level, I really dislike the way it reads in this case.
I didn't have a problem with that.
> May I suggest one of:
>
> - This LED group can be used for one or more Ethernet interfaces, however it is recommended that each interface use a dedicated LED group.
Bad sentence grammar.
> - This LED group can be used for one or more Ethernet interfaces. It is still recommended that each interface use a dedicated LED group, however.
Inverting the order to put the "however" at the end doesn't help IMO.
> - This LED group can be used for one or more Ethernet interfaces. (But it is recommended that each interface use a dedicated LED group.)
- This LED group can be used for one or more Ethernet interfaces, but it is recommended that each interface use a dedicated LED group.
?
> >
> > Other than that, looks good. Thanks.
> >
> > > + recommended that each Ethernet interface use a dedicated LED group.
> > >
> > > config ETRAX_NBR_LED_GRP_TWO
> > > bool "Use two LED groups"
---
~Randy
next prev parent reply other threads:[~2008-04-26 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 4:28 Matt LaPlante
2008-04-26 4:50 ` Randy Dunlap
2008-04-26 6:17 ` Matt LaPlante
2008-04-26 16:16 ` Randy Dunlap [this message]
2008-04-26 22:21 ` Matt LaPlante
2008-04-26 23:39 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080426091652.19503700.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=kernel1@cyberdogtech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®