Re: [PATCH] asm/unaligned.h doesn't work well as the very first include

[Sam Ravnborg <sam@ravnborg.org>]

On Sun, Apr 27, 2008 at 06:19:18AM +0100, Al Viro wrote:
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
>  net/mac80211/mesh.h      |    1 +
>  net/mac80211/mesh_hwmp.c |    1 -
>  2 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h
> index 742003d..9ee3aff 100644
> --- a/net/mac80211/mesh.h
> +++ b/net/mac80211/mesh.h
> @@ -13,6 +13,7 @@
>  
>  #include <linux/types.h>
>  #include <linux/jhash.h>
> +#include <asm/unaligned.h>
>  #include "ieee80211_i.h"
>  
>  
> diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
> index 02de8f1..3df8092 100644
> --- a/net/mac80211/mesh_hwmp.c
> +++ b/net/mac80211/mesh_hwmp.c
> @@ -7,7 +7,6 @@
>   * published by the Free Software Foundation.
>   */
>  
> -#include <asm/unaligned.h>
>  #include "mesh.h"

It has been discussed that any .h file should pull
in what it needs so the other of includes does not matter.
Some do them alphabetically.

Why not fix asm-*/unaligned.h so all users now and future
are fixed in one shot?

	Sam