From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750898AbYD1GWm (ORCPT ); Mon, 28 Apr 2008 02:22:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755508AbYD1GWR (ORCPT ); Mon, 28 Apr 2008 02:22:17 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:53037 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755227AbYD1GWQ (ORCPT ); Mon, 28 Apr 2008 02:22:16 -0400 Date: Mon, 28 Apr 2008 07:22:13 +0100 From: Al Viro To: Ian Kent Cc: Andrew Morton , Kernel Mailing List , autofs mailing list , linux-fsdevel Subject: Re: [PATCH] autofs4 - use lookup access intent to support recursive bind mounts Message-ID: <20080428062213.GB5882@ZenIV.linux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 28, 2008 at 02:14:54PM +0800, Ian Kent wrote: > > Hi Andrew, > > For autofs maps that recursively reference other map entries in their > mount point path we need to ensure that these mounts are performed > prior to the current mount request being done. We've used the access > system call, made just prior to performing the mount, to make this > happen. In the case of bind mounts, however, the lookup flags in > the path walk don't trigger a mount. To do this we need to also > trigger a mount when we see the LOOKUP_ACCESS flag. That's too fscking bad, since ->lookup() is about to lose access to nameidata *and* flags for anything but the last step. IOW, we'll need cleaner solution...