mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: ./fs/partitions/check.c: off-by-one error ?
Date: Mon, 28 Apr 2008 14:56:53 +0200	[thread overview]
Message-ID: <20080428125652.GD17054@duck.suse.cz> (raw)
In-Reply-To: <200804231843.00379.toralf.foerster@gmx.de>

On Wed 23-04-08 18:42:57, Toralf Förster wrote:
> At Tuesday 22 April 2008 12:38:29 Jan Kara wrote :
> >   This looks more like a strange interaction of your device size (it
> > claims to have 3902463 sectors) and your partitioning programs which
> > create partition ending at sector 3902464. Can you send the partition
> > table you have on the device? E.g:
> >   fdisk /dev/sda
> >   x
> >   p
> > 
> >   will print detailed information about the partition table.
> > 
> 
> n22 ~ # fdisk /dev/sda
> 
> The number of cylinders for this disk is set to 1267.
> There is nothing wrong with that, but this is larger than 1024,
> and could in certain setups cause problems with:
> 1) software that runs at boot time (e.g., old versions of LILO)
> 2) booting and partitioning software from other OSs
>    (e.g., DOS FDISK, OS/2 FDISK)
> 
> Command (m for help): x
> 
> Expert command (m for help): p
> 
> Disk /dev/sda: 56 heads, 55 sectors, 1267 cylinders
> 
> Nr AF  Hd Sec  Cyl  Hd Sec  Cyl     Start      Size ID
>  1 00   2   4    0  55  55  967        129    3902335 06
>  2 00   0   0    0   0   0    0          0          0 00
>  3 00   0   0    0   0   0    0          0          0 00
>  4 00   0   0    0   0   0    0          0          0 00
> 
> Expert command (m for help): q
> 
> n22 ~ # fdisk -l /dev/sda
> 
> Disk /dev/sda: 1998 MB, 1998061056 bytes
> 56 heads, 55 sectors/track, 1267 cylinders
> Units = cylinders of 3080 * 512 = 1576960 bytes
> Disk identifier: 0x00000000
> 
>    Device Boot      Start         End      Blocks   Id  System
> /dev/sda1               1        1268     1951167+   6  FAT16
> 
> I deleted +created the partition both manually and by the digikam
> but w/o success...
  Hmm, ok. This doesn't look like a kernel bug. At least if you created the
partition table in linux by fdisk (or some other partitioning program), it
should have created the partition one sector shorter. So please report this
as a bug of the partitioning program. Thanks.

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

      reply	other threads:[~2008-04-28 12:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-20 10:35 Toralf Förster
2008-04-22 10:38 ` Jan Kara
2008-04-22 15:32   ` Randy Dunlap
2008-04-22 15:48     ` Alan Stern
2008-04-23 16:42   ` Toralf Förster
2008-04-28 12:56     ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428125652.GD17054@duck.suse.cz \
    --to=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=toralf.foerster@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome