From: Ingo Molnar <mingo@elte.hu>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: vget_cycles() __always_inline
Date: Mon, 28 Apr 2008 17:24:22 +0200 [thread overview]
Message-ID: <20080428152422.GD18776@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0804270035200.30877@blonde.site>
* Hugh Dickins <hugh@veritas.com> wrote:
> Mark vget_cycles() as __always_inline, so gcc is never tempted to make
> the vsyscall vread_tsc() dive into kernel text, with resulting
> SIGSEGV.
>
> This was a self-inflicted wound: I've not seen that happen with
> unhacked sources; but for debug reasons I'd changed my x86/Makefile to
> compile no-unit-at-a-time, and that in conjunction with
> OPTIMIZE_INLINING=y ended up with vget_cycles() in kernel text.
> Perhaps it can happen in other ways: safer to use __always_inline.
applied, thanks Hugh - i agree that this is worth fixing.
Ingo
prev parent reply other threads:[~2008-04-28 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 23:39 Hugh Dickins
2008-04-28 15:24 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428152422.GD18776@elte.hu \
--to=mingo@elte.hu \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome