From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934885AbYD1PkF (ORCPT ); Mon, 28 Apr 2008 11:40:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935857AbYD1PjH (ORCPT ); Mon, 28 Apr 2008 11:39:07 -0400 Received: from smtp5.pp.htv.fi ([213.243.153.39]:34979 "EHLO smtp5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935848AbYD1PjE (ORCPT ); Mon, 28 Apr 2008 11:39:04 -0400 Date: Mon, 28 Apr 2008 18:38:31 +0300 From: Adrian Bunk To: Ingo Molnar Cc: Linus Torvalds , Linux Kernel Mailing List , Andrew Morton , Thomas Gleixner , "H. Peter Anvin" , Alexander van Heukelum , jdike@addtoit.com Subject: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline Message-ID: <20080428153831.GC2813@cs181133002.pp.htv.fi> References: <20080424215739.GA32378@elte.hu> <20080426151516.GA27894@elte.hu> <20080426172222.GD17345@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080426172222.GD17345@elte.hu> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes the following build error with UML and gcc 4.3: <-- snip --> ... CC fs/block_dev.o /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/block_dev.c: In function ‘blkdev_get_block’: /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/block_dev.c:42: sorry, unimplemented: inlining failed in call to ‘I_BDEV’: function body not available /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/block_dev.c:119: sorry, unimplemented: called from here /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/block_dev.c:42: sorry, unimplemented: inlining failed in call to ‘I_BDEV’: function body not available /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/block_dev.c:131: sorry, unimplemented: called from here make[2]: *** [fs/block_dev.o] Error 1 <-- snip --> Signed-off-by: Adrian Bunk --- cd324c3df8a964c6abe03828861238ea3083ba02 diff --git a/fs/block_dev.c b/fs/block_dev.c index 7d822fa..ce9ea3e 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -38,7 +38,7 @@ static inline struct bdev_inode *BDEV_I(struct inode *inode) return container_of(inode, struct bdev_inode, vfs_inode); } -inline struct block_device *I_BDEV(struct inode *inode) +struct block_device *I_BDEV(struct inode *inode) { return &BDEV_I(inode)->bdev; }