From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758712AbYD2IH0 (ORCPT ); Tue, 29 Apr 2008 04:07:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752948AbYD2IHL (ORCPT ); Tue, 29 Apr 2008 04:07:11 -0400 Received: from smtp6.pp.htv.fi ([213.243.153.40]:50111 "EHLO smtp6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbYD2IHJ (ORCPT ); Tue, 29 Apr 2008 04:07:09 -0400 Date: Tue, 29 Apr 2008 11:06:31 +0300 From: Adrian Bunk To: Linus Torvalds Cc: Ingo Molnar , Linux Kernel Mailing List , Andrew Morton , Thomas Gleixner , "H. Peter Anvin" , Alexander van Heukelum , jdike@addtoit.com Subject: Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline Message-ID: <20080429080631.GB28059@cs181133002.pp.htv.fi> References: <20080424215739.GA32378@elte.hu> <20080426151516.GA27894@elte.hu> <20080426172222.GD17345@elte.hu> <20080428153831.GC2813@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 28, 2008 at 05:41:11PM -0700, Linus Torvalds wrote: >... > > -inline struct block_device *I_BDEV(struct inode *inode) > > +struct block_device *I_BDEV(struct inode *inode) > > { > > return &BDEV_I(inode)->bdev; > > } > > There is NO WAY IN HELL this function shouldn't be inlined, >... Then CONFIG_OPTIMIZE_INLINING already broke it in your tree. > Linus cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed