From: Sam Ravnborg <sam@ravnborg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: riel@redhat.com, linux-kernel@vger.kernel.org,
ajackson@redhat.com, airlied@redhat.com,
benh@kernel.crashing.org
Subject: Re: [PATCH 1/3] make access_process_vm work on device memory
Date: Tue, 29 Apr 2008 21:19:46 +0200 [thread overview]
Message-ID: <20080429191946.GB32685@uranus.ravnborg.org> (raw)
In-Reply-To: <20080429121322.6da6b176.akpm@linux-foundation.org>
On Tue, Apr 29, 2008 at 12:13:22PM -0700, Andrew Morton wrote:
> On Tue, 29 Apr 2008 21:01:32 +0200
> Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > > urgh.
> > >
> > > We have HAVE_ARCH*
> > > We have __HAVE_ARCH*
> > > We have ARCH_HAS*
> > > We have __ARCH_HAS*
> > >
> > > what a mess.
> > >
> > > Probably the preferred (but still ugly) approach is to implement
> > > CONFIG_ARCH_*.
> > Only if it is a Kconfig symbol.
> >
> > We have recently started to use 'HAVE_*' for boolean symbols used
> > to select a specific function for one architecture.
> > See arch/Kconfig for a few samples.
> >
> > And Documentation/kbuild/kconfig-language.txt for usage hints.
> >
>
> I think what you're telling us is to use CONFIG_HAVE_IOREMAP_PROT?
I think so. But I just stumbled upon this mail and have not even tried
to follow what you discuss.
So yes - if it is a kconfig symbol.
And if it is a bool.
And if it has no dependencies, or we can create a helper
with no dependencies - so yes.
Sam
prev parent reply other threads:[~2008-04-29 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 15:32 Rik van Riel
2008-04-29 18:09 ` Andrew Morton
2008-04-29 18:32 ` Rik van Riel
2008-04-29 19:01 ` Sam Ravnborg
2008-04-29 19:13 ` Andrew Morton
2008-04-29 19:19 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429191946.GB32685@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@redhat.com \
--cc=ajackson@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®