From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761291AbYD2LLf (ORCPT ); Tue, 29 Apr 2008 07:11:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754877AbYD2LL1 (ORCPT ); Tue, 29 Apr 2008 07:11:27 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:49851 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754796AbYD2LL0 (ORCPT ); Tue, 29 Apr 2008 07:11:26 -0400 Date: Tue, 29 Apr 2008 20:11:26 +0900 From: KOSAKI Motohiro To: Mel Gorman Subject: Re: [PATCH] on memoryless node, /proc/pagetypeinfo is displayed slightly funny output. take2 Cc: kosaki.motohiro@jp.fujitsu.com, Shi Weihua , KAMEZAWA Hiroyuki , LKML , Andrew Morton In-Reply-To: <20080429104318.GA9622@csn.ul.ie> References: <20080429171457.3543.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080429104318.GA9622@csn.ul.ie> Message-Id: <20080429200710.354B.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I see what you mean. The headers for a node with no populated zones looks > a bit odd. I was briefly thrown by the check for N_HIGH_MEMORY wondering > why it was not a check for N_NORMAL_MEMORY. A double-check showed that > N_NORMAL_MEMORY only has meaning on CONFIG_HIGHMEM machines and a check for > "any memory on the node" should use N_HIGH_MEMORY which is what you do. > > So, your patch looks correct but unfortunately it is whitespace-damaged > and would not apply as-is. I included a whitespace-fixed version below for > convenience with a slightly clearer leader which I have acked. Oops, very sorry. I'll check my MUA settings again. and, very thank you for your excellent cleanups.