mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pekka Paalanen <pq@iki.fi>
To: Ingo Molnar <mingo@elte.hu>
Cc: Pekka Paalanen <pq@iki.fi>,
	linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Arjan van de Ven <arjan@infradead.org>,
	Pavel Roskin <proski@gnu.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC 1/3] mmiotrace full patch, preview 3
Date: Tue, 29 Apr 2008 23:40:21 +0300	[thread overview]
Message-ID: <20080429234021.071f7948@daedalus.pq.iki.fi> (raw)
In-Reply-To: <20080428214504.5c359195@daedalus.pq.iki.fi>

On Mon, 28 Apr 2008 21:45:04 +0300
Pekka Paalanen <pq@iki.fi> wrote:

> The current state is that mmiotrace seems to work fine, also on SMP,
> but on SMP there's a chance to miss events due to CPUs racing. At last
> the log produced via ftrace framework is up-to-spec. Inserting user
> comments (markers in mmiotrace-parlance) into the log is not yet
> supported. All in all, after some more testing on my part, IMHO this
> is in a mergeable state.

Ok, looks like I won't be able to do more testing than what I did today.
The sched-devel/latest tree has changes that break the out-of-tree DRM,
so I cannot test with Nouveau, and most likely the proprietary driver
will not work either. A very nice test would be to enable mmiotracing
as early in boot as convinient, but I don't know how to achieve that
with the ftrace framework.

I did notice two bugs in mmiotrace while looking at ioremap.c, so
I will follow here with three patches.

Tested with the patches and sched-devel/latest of
Tue, 29 Apr 2008 11:47:55 +0000
using testmmiotrace.ko and things looked fine.


Thanks.

-- 
Pekka Paalanen
http://www.iki.fi/pq/

  parent reply	other threads:[~2008-04-29 20:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-28 18:45 Pekka Paalanen
2008-04-28 18:55 ` [RFC 2/3] " Pekka Paalanen
2008-04-28 18:58 ` [RFC 1/3] " Pekka Paalanen
2008-04-28 19:02   ` [RFC 3/3] " Pekka Paalanen
2008-04-28 20:05 ` [RFC 1/3] " Ingo Molnar
2008-04-29 20:40 ` Pekka Paalanen [this message]
2008-04-29 20:43   ` [PATCH 1/3] x86 mmiotrace: fix page-unaligned ioremaps Pekka Paalanen
2008-04-29 20:45   ` [PATCH 2/3] x86 mmiotrace: use resource_size_t for phys addresses Pekka Paalanen
2008-04-29 20:46   ` [PATCH 3/3] mmiotrace: rename kmmio_probe::user_data to :private Pekka Paalanen
2008-04-29 20:52     ` Ingo Molnar
2008-05-01 15:38       ` [PATCH] x86 mmiotrace: page level is unsigned Pekka Paalanen
2008-05-01 17:45   ` [RFC 1/3] mmiotrace full patch, preview 3 Pekka Paalanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080429234021.071f7948@daedalus.pq.iki.fi \
    --to=pq@iki.fi \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=proski@gnu.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®