From: David Chinner <dgc@sgi.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: David Chinner <dgc@sgi.com>,
linux-next@vger.kernel.org, xfs-masters@oss.sgi.com,
Christoph Hellwig <hch@infradead.org>,
Lachlan McIlroy <lachlan@sgi.com>,
LKML <linux-kernel@vger.kernel.org>,
Linus <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH, XFS] Fix random.h include for non-debug builds
Date: Wed, 30 Apr 2008 17:11:16 +1000 [thread overview]
Message-ID: <20080430071116.GE108924158@sgi.com> (raw)
In-Reply-To: <20080430164218.9c2bfb1c.sfr@canb.auug.org.au>
On Wed, Apr 30, 2008 at 04:42:18PM +1000, Stephen Rothwell wrote:
> Hi David,
>
> On Wed, 30 Apr 2008 16:35:44 +1000 David Chinner <dgc@sgi.com> wrote:
> >
> > Ah, I see the problem - a CONFIG_XFS_DEBUG build includes linux/random.h
> > in a debug header file. That's probably why I didn't catch it (I need to
> > check the .config on my build test tree).
> >
> > I'll get it fixed properly, but in the mean time the include you've got
> > there will suffice...
>
> Could you make sure something gets sent to Linus pretty quickly as this
> breaks a lot of the powerpc builds at the moment (see
> http://kisskb.ellerman.id.au/kisskb/branch/3/).
It should break anything that builds a non-debug XFS, not just powerpc.
> Or should I do my patch
> up and sent it?
No, the correct patch is below. Linus, can you please apply?
Cheers,
Dave.
---
Include linux/random.h in all builds, not just debug.
Signed-off-by: Dave Chinner <dgc@sgi.com>
---
fs/xfs/linux-2.6/xfs_linux.h | 1 +
fs/xfs/support/debug.h | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_linux.h
===================================================================
--- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_linux.h 2008-04-22 15:06:11.000000000 +1000
+++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_linux.h 2008-04-30 16:38:38.754688626 +1000
@@ -75,6 +75,7 @@
#include <linux/delay.h>
#include <linux/log2.h>
#include <linux/spinlock.h>
+#include <linux/random.h>
#include <asm/page.h>
#include <asm/div64.h>
Index: 2.6.x-xfs-new/fs/xfs/support/debug.h
===================================================================
--- 2.6.x-xfs-new.orig/fs/xfs/support/debug.h 2007-08-02 22:13:10.000000000 +1000
+++ 2.6.x-xfs-new/fs/xfs/support/debug.h 2008-04-30 16:38:43.518080606 +1000
@@ -49,8 +49,6 @@ extern void assfail(char *expr, char *f,
#else /* DEBUG */
-#include <linux/random.h>
-
#define ASSERT(expr) \
(unlikely(expr) ? (void)0 : assfail(#expr, __FILE__, __LINE__))
prev parent reply other threads:[~2008-04-30 7:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 4:00 linux-next: xfs build failure Stephen Rothwell
2008-04-30 6:35 ` David Chinner
2008-04-30 6:42 ` Stephen Rothwell
2008-04-30 7:11 ` David Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080430071116.GE108924158@sgi.com \
--to=dgc@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome