From: Alasdair G Kergon <agk@redhat.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Anderson <andmike@linux.vnet.ibm.com>,
Mikulas Patocka <mpatocka@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Optimize lock in queue unplugging
Date: Wed, 30 Apr 2008 11:38:00 +0100 [thread overview]
Message-ID: <20080430103759.GM18935@agk.fab.redhat.com> (raw)
In-Reply-To: <20080430071415.GM12774@kernel.dk>
On Wed, Apr 30, 2008 at 09:14:15AM +0200, Jens Axboe wrote:
> So it's basically dm calling into blk_unplug() all the time, which
> doesn't check if the queue is plugged. The reason why I didn't like the
> initial patch is that ->unplug_fn() really should not be called unless
> the queue IS plugged. So how about this instead:
>
> http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=c44993018887e82abd49023e92e8d8b6000e03ed
>
> That's a lot more appropriate, imho.
Makes sense to me, ack.
Alasdair
--
agk@redhat.com
next prev parent reply other threads:[~2008-04-30 10:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 19:12 Mikulas Patocka
2008-04-29 19:25 ` Jens Axboe
2008-04-29 20:02 ` Mikulas Patocka
2008-04-29 20:05 ` Jens Axboe
2008-04-29 20:29 ` Mike Anderson
2008-04-30 7:14 ` Jens Axboe
2008-04-30 10:38 ` Alasdair G Kergon [this message]
2008-04-30 13:54 ` Mikulas Patocka
2008-05-04 19:11 ` Jens Axboe
2008-05-05 4:01 ` Mikulas Patocka
2008-05-07 7:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080430103759.GM18935@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=andmike@linux.vnet.ibm.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome