From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932344AbYEAVj7 (ORCPT ); Thu, 1 May 2008 17:39:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761482AbYEAVjv (ORCPT ); Thu, 1 May 2008 17:39:51 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:37252 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1757440AbYEAVju (ORCPT ); Thu, 1 May 2008 17:39:50 -0400 Date: Thu, 01 May 2008 14:39:49 -0700 (PDT) Message-Id: <20080501.143949.20091241.davem@davemloft.net> To: alan@lxorguk.ukuu.org.uk Cc: hch@infradead.org, mb@bu3sch.de, jbarnes@virtuousgeek.org, linville@tuxdriver.com, andi@firstfloor.org, mingo@elte.hu, bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] Add API for weak DMA masks From: David Miller In-Reply-To: <20080501172913.08975881@core> References: <200805011638.15910.mb@bu3sch.de> <20080501153618.GA470@infradead.org> <20080501172913.08975881@core> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alan Cox Date: Thu, 1 May 2008 17:29:13 +0100 > We have tons of drivers that go > > try and set 64bit > oh failed > try and set 32 bit > oh worked > > When what most actually want is "set it no more than this wide" - a > request or even a "pci_set_best_mask()" type idea. > > Lots less code duplication. Agreed, it's a templated construct and it belongs in one spot.