mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Andrew Morton <akpm@linux-foundation.org>,
	Florian Fainelli <florian.fainelli@telecomint.eu>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: Ingo, no more kconfig patches
Date: Thu, 1 May 2008 05:12:54 +0300	[thread overview]
Message-ID: <20080501021254.GR29330@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <20080501020645.GD27574@elte.hu>

On Thu, May 01, 2008 at 04:06:45AM +0200, Ingo Molnar wrote:
> 
> * Adrian Bunk <bunk@kernel.org> wrote:
> 
> > The bug is in arch/x86/Kconfig .
> > 
> > Caused by commit 4cf31841762954ad2868156ccba94d798a16630f (x86: 
> > mach-rdc321x Kconfig fix).
> 
> ah, indeed - Florian Cc:-ed. Preliminary quick hack below.

Why couldn't you *read* my email completely before sending yet another 
kconfig patch?

I said:
Roman's patch to remove the need to select NEW_LEDS that just appeared 
in another thread will actually also fix your bug (and makes my idea 
to add a "select NEW_LEDS" to X86_RDC321X obsolete).

> 	Ingo
> 
> --------------->
> Subject: rdc: leds hack
> From: Ingo Molnar <mingo@elte.hu>
> Date: Thu May 01 03:46:22 CEST 2008
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>  arch/x86/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: linux/arch/x86/Kconfig
> ===================================================================
> --- linux.orig/arch/x86/Kconfig
> +++ linux/arch/x86/Kconfig
> @@ -322,6 +322,7 @@ config X86_RDC321X
>  	select GENERIC_GPIO
>  	select LEDS_CLASS
>  	select LEDS_GPIO
> +	select NEW_LEDS
>  	help
>  	  This option is needed for RDC R-321x system-on-chip, also known
>  	  as R-8610-(G).

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2008-05-01  2:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 20:03 [patch] input: JOYSTICK_XPAD build fix Ingo Molnar
2008-04-30 21:02 ` Dmitry Torokhov
2008-04-30 21:13   ` Ingo Molnar
2008-04-30 23:01     ` Ingo, no more kconfig patches Adrian Bunk
2008-05-01  1:17       ` Ingo Molnar
2008-05-01  1:37         ` Adrian Bunk
2008-05-01  2:06           ` Ingo Molnar
2008-05-01  2:12             ` Adrian Bunk [this message]
2008-05-01  2:52       ` Ingo Molnar
2008-05-01 11:59         ` Adrian Bunk
2008-05-03 19:14           ` Ingo Molnar
2008-05-03 19:17             ` Ingo Molnar
2008-05-03 20:24             ` Adrian Bunk
2008-05-03 21:03               ` Ingo Molnar
2008-05-03 21:24                 ` Adrian Bunk
2008-05-03 21:38                   ` Sam Ravnborg
2008-05-03 22:07                     ` Adrian Bunk
2008-05-04  7:36                       ` Sam Ravnborg
2008-05-04  7:49                         ` Adrian Bunk
2008-05-03 21:52                   ` Ingo Molnar
2008-05-03 22:03                     ` Adrian Bunk
2008-05-04  3:54                       ` Valdis.Kletnieks
2008-05-04  7:47                         ` Adrian Bunk
2008-05-03 23:22                   ` Thomas Gleixner
2008-05-04  0:34                     ` Adrian Bunk
2008-05-03 21:17               ` Krzysztof Halasa
2008-05-03 21:47                 ` Adrian Bunk
2008-05-03 22:13                   ` Krzysztof Halasa
2008-05-03 22:29                     ` Adrian Bunk
2008-05-03 23:37                       ` Krzysztof Halasa
2008-05-04  0:49                         ` Adrian Bunk
2008-05-04 12:18                           ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080501021254.GR29330@cs181133002.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=florian.fainelli@telecomint.eu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®