From: Adrian Bunk <bunk@kernel.org>
To: Andres Salomon <dilinger@queued.net>
Cc: David Woodhouse <dwmw2@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: olpc_battery_trigger_uevent() is unused
Date: Thu, 1 May 2008 05:16:24 +0300 [thread overview]
Message-ID: <20080501021624.GT29330@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <20080429190137.5b519463@ephemeral>
On Tue, Apr 29, 2008 at 07:01:37PM -0400, Andres Salomon wrote:
> On Wed, 30 Apr 2008 01:29:51 +0300
> Adrian Bunk <bunk@kernel.org> wrote:
>
> > drivers/power/olpc_battery.c:olpc_battery_trigger_uevent() is unused.
> >
> > Should it have been used?
> >
> > cu
> > Adrian
> >
>
> It will get used once the olpc power management code makes it
> upstream. The olpc_register_battery_callback stuff that Andrew removed
> was related to that.
>
> Remove it now if you like, but I'm hoping to get it in for the 2.6.27
> merge window.
I'm not that trigger-happy. ;-)
I was actually more interested in whether it should have been used
(AKA there would be a bug somewhere).
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2008-05-01 2:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 22:29 Adrian Bunk
2008-04-29 23:01 ` Andres Salomon
2008-05-01 2:16 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501021624.GT29330@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=dilinger@queued.net \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®