From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1763351AbYEAVGJ@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1763351AbYEAVGJ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 1 May 2008 17:06:09 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759134AbYEAVFx
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 1 May 2008 17:05:53 -0400
Received: from e34.co.us.ibm.com ([32.97.110.152]:56642 "EHLO
	e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758686AbYEAVFw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 1 May 2008 17:05:52 -0400
Date: Thu, 1 May 2008 16:05:50 -0500
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Serge E. Hallyn" <serue@us.ibm.com>, Greg KH <gregkh@suse.de>,
       Benjamin Thery <benjamin.thery@bull.net>, linux-kernel@vger.kernel.org,
       Al Viro <viro@ftp.linux.org.uk>, Tejun Heo <htejun@gmail.com>,
       Daniel Lezcano <dlezcano@fr.ibm.com>,
       Pavel Emelyanov <xemul@openvz.org>, netdev@vger.kernel.org
Subject: Re: [PATCH 00/10] sysfs tagged directories
Message-ID: <20080501210550.GA22534@sergelap.austin.ibm.com>
References: <20080429171015.473938697@theryb.frec.bull.fr> <20080429173621.GA16625@suse.de> <20080429180445.GA18110@sergelap.austin.ibm.com> <20080429184151.GA19794@suse.de> <20080429193417.GA19282@sergelap.austin.ibm.com> <20080501031341.GD4911@suse.de> <20080501151051.GB16038@sergelap.austin.ibm.com> <m11w4lho08.fsf@frodo.ebiederm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m11w4lho08.fsf@frodo.ebiederm.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Quoting Eric W. Biederman (ebiederm@xmission.com):
> "Serge E. Hallyn" <serue@us.ibm.com> writes:
> 
> > Quoting Greg KH (gregkh@suse.de):
> > Now before moving veth1 to the new netns, we have in the container:
> > /sys/class/net:
> > lo  sit0
> >
> > /sys/devices/virtual/net:
> > lo  sit0
> >
> > and after moving veth1, we have in the container:
> >
> > /sys/class/net:
> > lo  sit0  veth1
> >
> > /sys/devices/virtual/net:
> > lo  sit0
> >
> > In the parent network namespace, veth1 is removed from /sys/class/net
> > but remains in /sys/devices/virtual/net.
> 
> The symlink is gone by the real directory remains?
> 
> > I'm not sure whether this is the renaming bug that Daniel Lezcano's
> > patch addresses.  If not (as I suspect) then that clearly needs to be
> > fixed.
> >
> > Benjamin can you play around with this and test it with Daniel's
> > patch?
> 
> Darn.  It appears we have a regression in this patchset.
> That part used to work.
> 
> I was thinking of blaming sysfs_rename_link.  But it the
> links are fine so it looks more likely that sysfs has morphed once
> again and we have  a reference counting issue or something similar.
> Yuck. d_move and the other moves should have worked.
> 
> >From a purely get the good less controversial parts of this
> patchset in.  I suggest we look at patches 7/10 and 8/10 (without
> the tag_ops).  And introduce and start using sysfs_delete_link
> and sysfs_rename_link.  That code seems pretty stable and is
> generally a code reduction all by itself by reducing a common
> idiom into a single function.
> 
> Eric

Ok as it turns out Benjamin Thery does in fact have a patch to fix this.
Benjamin, please send your renaming patch out tomorrow if you can?

I guess this is why I didn't really see the problem Benjamin said there
was - it just works with SYSFS_DEPRECATED  :)

-serge