From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933686AbYEBJqq (ORCPT ); Fri, 2 May 2008 05:46:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759418AbYEBJqc (ORCPT ); Fri, 2 May 2008 05:46:32 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:44982 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1758905AbYEBJqb (ORCPT ); Fri, 2 May 2008 05:46:31 -0400 Date: Fri, 02 May 2008 02:46:31 -0700 (PDT) Message-Id: <20080502.024631.187057697.davem@davemloft.net> To: den@openvz.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, adobriyan@openvz.org, ebiederm@xmission.com Subject: Re: [PATCH 3/12] net: assign PDE->data before gluing PDE into /proc tree From: David Miller In-Reply-To: <1209467602-20001-3-git-send-email-den@openvz.org> References: <1209467538.29647.11.camel@iris.sw.ru> <1209467602-20001-3-git-send-email-den@openvz.org> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Denis V. Lunev" Date: Tue, 29 Apr 2008 15:13:13 +0400 > Simply replace proc_create and further data assigned with proc_create_data. > Additionally, there is no need to assign NULL to PDE->data after creation, > /proc generic has already done this for us. > > Signed-off-by: Denis V. Lunev Applied, thanks.