mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steve Wise <swise@opengridcomputing.com>
To: rdreier@cisco.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	general@lists.openfabrics.org
Subject: [PATCH 2.6.26 2/3] RDMA/cxgb3: Silently ignore close reply after abort.
Date: Fri, 02 May 2008 11:17:43 -0500	[thread overview]
Message-ID: <20080502161743.30500.27928.stgit@dell3.ogc.int> (raw)
In-Reply-To: <20080502161741.30500.95337.stgit@dell3.ogc.int>


Remove bad BUG_ON() in close_con_rpl().  It is possible to get a close_rpl
message on a dead connection.  The sequence is:
	host refs ep for close exchange
	host posts close_req
	hw posts PEER_ABORT from incoming RST
	host marks ep DEAD
	host posts ABORT_RPL and releases ep resources
	hw posts CLOSE_RPL
	host derefs ep and ep freed.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---

 drivers/infiniband/hw/cxgb3/iwch_cm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
index f4f3c9e..b2db0a9 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
@@ -1650,8 +1650,8 @@ static int close_con_rpl(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
 		release = 1;
 		break;
 	case ABORTING:
-		break;
 	case DEAD:
+		break;
 	default:
 		BUG_ON(1);
 		break;

  reply	other threads:[~2008-05-02 16:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-02 16:17 [PATCH 2.6.26 1/3] RDMA/cxgb3: QP flush fixes Steve Wise
2008-05-02 16:17 ` Steve Wise [this message]
2008-05-02 16:17 ` [PATCH 2.6.26 3/3] RDMA/cxgb3: Bump up the mpa connection setup timeout Steve Wise
2008-05-02 17:58 ` [PATCH 2.6.26 1/3] RDMA/cxgb3: QP flush fixes Roland Dreier
2008-05-02 20:16   ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080502161743.30500.27928.stgit@dell3.ogc.int \
    --to=swise@opengridcomputing.com \
    --cc=general@lists.openfabrics.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®