From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754953AbYEDImg (ORCPT ); Sun, 4 May 2008 04:42:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752159AbYEDIm3 (ORCPT ); Sun, 4 May 2008 04:42:29 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:38024 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125AbYEDIm1 (ORCPT ); Sun, 4 May 2008 04:42:27 -0400 Date: Sun, 4 May 2008 10:42:05 +0200 From: Ingo Molnar To: Sam Ravnborg Cc: Vegard Nossum , Roman Zippel , Adrian Bunk , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kconfig: warn about complex selects Message-ID: <20080504084205.GB21859@elte.hu> References: <20080504054044.GA32030@damson> <20080504082147.GA17276@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080504082147.GA17276@uranus.ravnborg.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Sam Ravnborg wrote: > On Sun, May 04, 2008 at 07:40:44AM +0200, Vegard Nossum wrote: > > Hi, > > > > Given recent discussion about kconfig and the "select" feature, I have made > > the following quick & dirty patch to detect what I call "complex selects". > > > > For v2.6.25, I get these warnings: > > sound/pci/Kconfig:512:error: found complex select: SND_FM801_TEA575X -> VIDEO_V4L1 > > drivers/ide/Kconfig:890:error: found complex select: ETRAX_IDE -> BLK_DEV_IDEDMA > > drivers/acpi/Kconfig:185:error: found complex select: ACPI_HOTPLUG_CPU -> ACPI_CONTAINER > > > > While for v2.6.26-rc1, I get these: > > sound/pci/Kconfig:528:error: found complex select: SND_FM801_TEA575X -> VIDEO_V4L1 > > drivers/media/video/em28xx/Kconfig:2:error: found complex select: VIDEO_EM28XX -> MEDIA_TUNER > > drivers/media/video/bt8xx/Kconfig:2:error: found complex select: VIDEO_BT848 -> MEDIA_TUNER > > drivers/media/video/saa7134/Kconfig:2:error: found complex select: VIDEO_SAA7134 -> MEDIA_TUNER > > drivers/media/video/cx88/Kconfig:2:error: found complex select: VIDEO_CX88 -> MEDIA_TUNER > > drivers/media/video/cx23885/Kconfig:2:error: found complex select: VIDEO_CX23885 -> MEDIA_TUNER > > drivers/media/video/ivtv/Kconfig:2:error: found complex select: VIDEO_IVTV -> MEDIA_TUNER > > drivers/media/video/cx18/Kconfig:2:error: found complex select: VIDEO_CX18 -> MEDIA_TUNER > > drivers/media/video/pvrusb2/Kconfig:2:error: found complex select: VIDEO_PVRUSB2 -> MEDIA_TUNER > > drivers/media/video/Kconfig:690:error: found complex select: VIDEO_MXB -> MEDIA_TUNER > > drivers/media/video/usbvision/Kconfig:2:error: found complex select: VIDEO_USBVISION -> MEDIA_TUNER > > drivers/acpi/Kconfig:188:error: found complex select: ACPI_HOTPLUG_CPU -> ACPI_CONTAINER > > > > (In other words, the number of these has increased significantly since the > > last release, and these will probably be hit as compile errors at one point > > or another.) > > > > I am not a kconfig expert, so I might have missed some things. Roman, is this > > even remotely good? I think it's probably a good start anyway. > > I did a small test of this using following configuration: > config A > bool "a" > > config B > bool "b" > depends on A > default AA || AAA > > config BB > bool "bb" > depends on A > > config C > bool "c" > select B > > config CC > bool "cc" > select BB > > > I had expected a warning about complex select for both C and CC. But > only C triggered the warning due to the complex default value of B. So > we need to work on this a bit more. > > But great to see code instead of just talking! agreed, very cool stuff Vegard! :) Ingo