From: Sam Ravnborg <sam@ravnborg.org>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Roman Zippel <zippel@linux-m68k.org>,
Adrian Bunk <bunk@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: warn about complex selects
Date: Sun, 4 May 2008 13:42:25 +0200 [thread overview]
Message-ID: <20080504114225.GA19074@uranus.ravnborg.org> (raw)
In-Reply-To: <20080504110038.GA8532@damson>
On Sun, May 04, 2008 at 01:00:38PM +0200, Vegard Nossum wrote:
> Okay, here's try #2. (That's what I get for making patches too early in the
> morning.)
>
> This checks dependencies instead of the "default" property. I don't know how
> useful this is, though, as it will generate some false positives. Actually,
> a lot of them.
Consider following simple Kconfig:
config A
bool "a"
config B
bool "b"
depends on A
config C
bool "c"
select B
config D
bool "d"
depends on A
select B
We should try to coe up with something that warns on
on the select in "config C", because B has dependencies C
does not have.
The select in D is OK since D has at least the same dependencies
as B.
So if we had a expr_is_subset_of(expr *e1, expr *e2)....
Roman - what do you think?
Sam
next prev parent reply other threads:[~2008-05-04 11:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 5:40 Vegard Nossum
2008-05-04 6:28 ` Bernd Eckenfels
2008-05-04 8:21 ` Sam Ravnborg
2008-05-04 8:42 ` Ingo Molnar
2008-05-04 8:56 ` Vegard Nossum
2008-05-04 11:00 ` Vegard Nossum
2008-05-04 11:42 ` Sam Ravnborg [this message]
2008-05-04 8:48 ` Ingo Molnar
2008-05-06 3:43 ` Roman Zippel
2008-05-06 6:26 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080504114225.GA19074@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=vegard.nossum@gmail.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®