From: Miklos Szeredi <miklos@szeredi.hu>
To: akpm@linux-foundation.org
Cc: hch@infradead.org, viro@ZenIV.linux.org.uk,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [patch 06/15] sysfs: dont call notify_change
Date: Mon, 05 May 2008 11:54:47 +0200 [thread overview]
Message-ID: <20080505095516.130659599@szeredi.hu> (raw)
In-Reply-To: <20080505095440.820370974@szeredi.hu>
[-- Attachment #1: sysfs_notify_change_cleanup.patch --]
[-- Type: text/plain, Size: 1424 bytes --]
From: Miklos Szeredi <mszeredi@suse.cz>
sysfs_chmod_file() calls notify_change() to change the permission bits
on a sysfs file. Replace with explicit call to sysfs_setattr() and
fsnotify_change().
This is equivalent, except that security_inode_setattr() is not
called. This function is called by drivers, so the security checks do
not make any sense.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: Greg Kroah-Hartman <gregkh@suse.de>
---
fs/sysfs/file.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: linux-2.6/fs/sysfs/file.c
===================================================================
--- linux-2.6.orig/fs/sysfs/file.c 2008-05-05 11:29:21.000000000 +0200
+++ linux-2.6/fs/sysfs/file.c 2008-05-05 11:29:26.000000000 +0200
@@ -18,6 +18,7 @@
#include <linux/poll.h>
#include <linux/list.h>
#include <linux/mutex.h>
+#include <linux/fsnotify.h>
#include <asm/uaccess.h>
#include "sysfs.h"
@@ -585,9 +586,11 @@ int sysfs_chmod_file(struct kobject *kob
newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO);
newattrs.ia_valid = ATTR_MODE | ATTR_CTIME;
- rc = notify_change(victim, &newattrs);
+ newattrs.ia_ctime = current_fs_time(inode->i_sb);
+ rc = sysfs_setattr(victim, &newattrs);
if (rc == 0) {
+ fsnotify_change(victim, newattrs.ia_valid);
mutex_lock(&sysfs_mutex);
victim_sd->s_mode = newattrs.ia_mode;
mutex_unlock(&sysfs_mutex);
--
next prev parent reply other threads:[~2008-05-05 9:58 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 9:54 [patch 00/15] VFS fixes and cleanups Miklos Szeredi
2008-05-05 9:54 ` [patch 01/15] ecryptfs: clean up (un)lock_parent Miklos Szeredi
2008-05-05 10:59 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 02/15] nfsd: clean up mnt_want_write calls Miklos Szeredi
2008-05-05 10:59 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 03/15] cgroup: dont call vfs_mkdir Miklos Szeredi
2008-05-05 11:00 ` Christoph Hellwig
2008-05-05 12:32 ` Miklos Szeredi
2008-05-05 13:08 ` Christoph Hellwig
2008-05-05 13:29 ` Miklos Szeredi
2008-05-05 13:33 ` Christoph Hellwig
2008-05-05 13:43 ` Miklos Szeredi
2008-05-05 13:46 ` Christoph Hellwig
2008-05-05 13:57 ` Miklos Szeredi
2008-05-05 17:22 ` Paul Menage
2008-05-05 9:54 ` [patch 04/15] reiserfs: dont call vfs_rmdir Miklos Szeredi
2008-05-05 9:54 ` [patch 05/15] reiserfs: dont call notify_change Miklos Szeredi
2008-05-05 9:54 ` Miklos Szeredi [this message]
2008-05-06 4:15 ` [patch 06/15] sysfs: " Greg KH
2008-05-06 6:28 ` Miklos Szeredi
2008-05-06 6:48 ` Greg KH
2008-05-05 9:54 ` [patch 07/15] hpfs: " Miklos Szeredi
2008-05-08 0:42 ` Mikulas Patocka
2008-05-05 9:54 ` [patch 08/15] fat: " Miklos Szeredi
2008-05-05 19:45 ` OGAWA Hirofumi
2008-05-06 8:49 ` Miklos Szeredi
2008-05-06 9:27 ` OGAWA Hirofumi
2008-05-05 9:54 ` [patch 09/15] vfs: immutable inode checking cleanup Miklos Szeredi
2008-05-05 11:01 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 10/15] vfs: truncate: dont check immutable twice Miklos Szeredi
2008-05-05 11:04 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 11/15] vfs: truncate: append-only checking cleanup Miklos Szeredi
2008-05-05 11:12 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 12/15] vfs: create file_truncate() helper Miklos Szeredi
2008-05-05 11:06 ` Christoph Hellwig
2008-05-05 12:35 ` Miklos Szeredi
2008-05-05 9:54 ` [patch 13/15] vfs: utimes cleanup Miklos Szeredi
2008-05-05 11:30 ` Christoph Hellwig
2008-05-05 12:39 ` Miklos Szeredi
2008-05-05 13:04 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 14/15] vfs: utimes immutable fix Miklos Szeredi
2008-05-05 11:14 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 15/15] vfs: splice remove_suid() cleanup Miklos Szeredi
2008-05-05 11:11 ` Christoph Hellwig
2008-05-07 7:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080505095516.130659599@szeredi.hu \
--to=miklos@szeredi.hu \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®