From: Sam Ravnborg <sam@ravnborg.org>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] kconfig: make oldconfig less chatty and clean up conf.c
Date: Tue, 6 May 2008 06:37:36 +0200 [thread overview]
Message-ID: <20080506043736.GB13366@uranus.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0805060455590.30555@scrub.home>
On Tue, May 06, 2008 at 05:08:40AM +0200, Roman Zippel wrote:
> Hi,
>
> On Sun, 4 May 2008, Sam Ravnborg wrote:
>
> > We now check for valid stadin in both cases and this
> > may break a script here and there.
>
> I strongly disagree with this, please preserve the old behaviour. It took
> a while to work out the current behaviour.
> Only silentoldconfig checks for stdin because it's used as hook during
> kbuild to verify the config. For all other interactive targets the user
> has to know what he's doing, e.g. it's valid to do "yes '' | make
> oldconfig".
I will test a bit more and may revert to the old behaviour.
One good thing with the new behaviour is that
make oldconfig > /dev/null
does not hang if there is new symbols - and I would like to keep
it so.
>
> > - switch (input_mode) {
> > - case set_no: name = "allno.config"; break;
> > - case set_mod: name = "allmod.config"; break;
> > - case set_yes: name = "allyes.config"; break;
> > - case set_random: name = "allrandom.config"; break;
> > - default: break;
> > - }
> > - if (!stat(name, &tmpstat))
> > - conf_read_simple(name, S_DEF_USER);
> > - else if (!stat("all.config", &tmpstat))
> > - conf_read_simple("all.config", S_DEF_USER);
> > - break;
> > - default:
> > - break;
> > }
>
> This isn't yet in aconf.c.
On purpose. It is very very seldom used and with K=file
it is now much easier to specify a base configuration.
So no need for all the special filenames.
Sam
next prev parent reply other threads:[~2008-05-06 4:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 20:47 kconfig frontend updates Sam Ravnborg
2008-05-02 20:49 ` [PATCH] kconfig: add support for K=file sam
2008-05-02 20:49 ` [PATCH] kconfig: drop all*config support in conf.c sam
2008-05-02 20:49 ` [PATCH] kconfig: conf is less chatty sam
2008-05-02 20:49 ` [PATCH] kconfig: .gitignore aconf sam
2008-05-02 20:49 ` [PATCH] kconfig: kill the warning "trying to assign nonexistent symbol" sam
2008-05-02 21:01 ` kconfig frontend updates Sam Ravnborg
2008-05-04 18:57 ` Sam Ravnborg
2008-05-04 18:59 ` [PATCH 1/2] kconfig: introduce K= support Sam Ravnborg
2008-05-06 2:55 ` Roman Zippel
2008-05-06 4:34 ` Sam Ravnborg
2008-05-04 18:59 ` [PATCH 2/2] kconfig: make oldconfig less chatty and clean up conf.c Sam Ravnborg
2008-05-06 3:08 ` Roman Zippel
2008-05-06 4:37 ` Sam Ravnborg [this message]
2008-05-06 9:03 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506043736.GB13366@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®