mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Gregory Haskins <ghaskins@novell.com>
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org,
	David Bahi <dbahi@novell.com>
Subject: Re: [PATCH] sched: fix SCHED_OTHER balance iterator to include all tasks
Date: Tue, 6 May 2008 14:06:16 +0200	[thread overview]
Message-ID: <20080506120616.GI32591@elte.hu> (raw)
In-Reply-To: <20080505142739.24888.31658.stgit@lsg>


* Gregory Haskins <ghaskins@novell.com> wrote:

> Hi Ingo,
>  The follow patch applies to sched-devel.  I know the original 
>  function was somehow trying to protect against dequeueing by 
>  pre-iterating.  I am not sure if I captured the intent properly in 
>  that regard.  What I can say is that the old algorithm would miss 
>  tasks, and that is now fixed.  It may need further adjustment if I 
>  missed the pre-iterating operation.
> 
> Hi Peter,
>  I was wrong earlier when I mentioned there might be a problem with 
>  entity_is_task().  I think this was the root cause of what I was 
>  seeing. Sorry for the red-herring.

applied Gregory, thanks. Nice fix! Peter, do you concur with Gregory's 
analysis?

	Ingo

  reply	other threads:[~2008-05-06 12:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 14:31 Gregory Haskins
2008-05-06 12:06 ` Ingo Molnar [this message]
2008-05-08  8:11   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080506120616.GI32591@elte.hu \
    --to=mingo@elte.hu \
    --cc=dbahi@novell.com \
    --cc=ghaskins@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®