mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pavel Machek <pavel@suse.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	kaszak@gmail.com, lcostantino@gmail.com,
	linux-wireless@vger.kernel.org
Subject: Re: w35und: fixed nasty stack overflow, I can actually ssh over this
Date: Tue, 6 May 2008 14:35:36 +0200	[thread overview]
Message-ID: <20080506123536.GM32591@elte.hu> (raw)
In-Reply-To: <20080505205617.GD7273@elf.ucw.cz>


* Pavel Machek <pavel@suse.cz> wrote:

> Removed nasty stack overflow, and got transmit of big packets to work. 
> I can now actually do ssh over softmac-based driver.
> 
> Unindent code to make it more readable.

> --- a/arch/x86/kernel/traps_32.c
> +++ b/arch/x86/kernel/traps_32.c
> @@ -146,11 +146,16 @@ static inline unsigned long print_contex
>  				unsigned long *stack, unsigned long bp,
>  				const struct stacktrace_ops *ops, void *data)
>  {
> +	int max = 5;
>  	struct stack_frame *frame = (struct stack_frame *)bp;
>  
>  	while (valid_stack_ptr(tinfo, stack, sizeof(*stack))) {
>  		unsigned long addr;
>  
> +		if (!max)
> +			return;
> +		max--;
> +

hm, you got into an infinite loop here, right? Could you please send 
this bit as a separate patch - and i guess it should use 
kstack_depth_to_print instead of '5'?

	Ingo

  reply	other threads:[~2008-05-06 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 20:56 Pavel Machek
2008-05-06 12:35 ` Ingo Molnar [this message]
2008-05-06 12:39   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080506123536.GM32591@elte.hu \
    --to=mingo@elte.hu \
    --cc=kaszak@gmail.com \
    --cc=lcostantino@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®