From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757560AbYEGBOS (ORCPT ); Tue, 6 May 2008 21:14:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754742AbYEGBN6 (ORCPT ); Tue, 6 May 2008 21:13:58 -0400 Received: from out1.smtp.messagingengine.com ([66.111.4.25]:39550 "EHLO out1.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753649AbYEGBN5 (ORCPT ); Tue, 6 May 2008 21:13:57 -0400 X-Sasl-enc: BS9c2V5whay59rUVQi3DYR331lwzTffnBDJqPJj1sS9c 1210122836 Date: Tue, 6 May 2008 22:13:54 -0300 From: Henrique de Moraes Holschuh To: Shaohua Li Cc: Holger Macht , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, "Accardi, Kristen C" Subject: Re: [PATCH] bay: Exit if notify handler cannot be installed Message-ID: <20080507011354.GA8163@khazad-dum.debian.net> References: <20080505202508.GA3690@homac> <20080506091522.GA4378@homac> <1210065811.12668.1.camel@sli10-desk.sh.intel.com> <20080506151846.GA22828@khazad-dum.debian.net> <1210122279.27316.2.camel@sli10-desk.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1210122279.27316.2.camel@sli10-desk.sh.intel.com> X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 07 May 2008, Shaohua Li wrote: > On Tue, 2008-05-06 at 12:18 -0300, Henrique de Moraes Holschuh wrote: > > On Tue, 06 May 2008, Shaohua Li wrote: > > > The bay driver is duplicated with libata, I thought we should delete it. > > > See bug http://bugzilla.kernel.org/show_bug.cgi?id=9526 > > > > The bay driver is currently useless, BUT it should handle a lot of stuff > > libata won't, such as bay batteries, bay floppies, and anything else in > > a bay that is not a hard disk. > > > > The fact that the driver currently looks only after disks is just a bug. > > It should, in fact, bind to any ejectable device not already handled by > > a different driver. > Isn't this the job of acpi dock driver? No, but I actually fail to see why do we even care about the difference from a dock to a bay. Dock *could* be made to handle both. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh