From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763386AbYEGWaR (ORCPT ); Wed, 7 May 2008 18:30:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751644AbYEGW2z (ORCPT ); Wed, 7 May 2008 18:28:55 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:50683 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933332AbYEGW2v (ORCPT ); Wed, 7 May 2008 18:28:51 -0400 Date: Thu, 8 May 2008 00:29:37 +0200 From: Pavel Machek To: Thomas Gleixner Cc: Adrian Bunk , Rene Herman , Yinghai Lu , Ingo Molnar , Linux Kernel , hpa@zytor.com, torvalds@linux-foundation.org, akpm@linux-foundation.org Subject: Re: 2.6.26, PAT and AMD family 6 Message-ID: <20080507222937.GI18516@elf.ucw.cz> References: <48210A71.1060409@keyaccess.nl> <86802c440805061939q39ff5500h3c9e229ecbc6b2e6@mail.gmail.com> <20080507124650.GD29935@cs181133002.pp.htv.fi> <48221AE3.6020602@keyaccess.nl> <20080507214646.GC14951@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > His commit ***added*** the three copies of the same code. > > And you are not able to ******look******* over the brim of your tea > cup and accept that one of them is 64 bit and the others are a tribute > to the not yet distangled shit. There would have been a cleaner and > better way to solve this, but there is always a better and cleaner way > to do things. Existing code being a mess is not an excuse for messing it up a bit more. Which is exactly what Yinghai did. > Why dont you send a cleanup patch which fixes the three copies problem > instead of spending your time with writing up ivory tower pieces of > wisdom ? Because no ammount of cleanup patches will solve "Ingo did not even notice missing changelog, and 2 NAKs"? commit 9307cacad0dfe3749f00303125c6f7f0523e5616 tree bc28bf08dc18dacbb2654a9a368f4e09c580dfab parent a7c7d0e91daebd7c5e51f9416d612b6a15e7e79a author Yinghai Lu Mon, 24 Mar 2008 23:24:34 -0700 committer Ingo Molnar Thu, 17 Apr 2008 17:41:20 +0200 x86: pat cpu feature bit setting for known cpus Signed-off-by: Yinghai Lu Signed-off-by: Ingo Molnar Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html