From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759767AbYEHAIe (ORCPT ); Wed, 7 May 2008 20:08:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754656AbYEHAIX (ORCPT ); Wed, 7 May 2008 20:08:23 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:36595 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753914AbYEHAIW (ORCPT ); Wed, 7 May 2008 20:08:22 -0400 Date: Thu, 08 May 2008 09:08:00 +0900 From: KOSAKI Motohiro To: Christoph Lameter Subject: Re: [PATCH] mm/page_alloc.c: fix a typo Cc: kosaki.motohiro@jp.fujitsu.com, Li Zefan , Andrew Morton , LKML , "linux-mm@kvack.org" In-Reply-To: References: <482029E7.6070308@cn.fujitsu.com> Message-Id: <20080508090647.4A7B.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Sorry for the noise, but the signed-off was eaten. :( > > Maybe I should leave a blank line before the signed-off. > > I think the | there was some developers attempt to avoid gcc generating > too many branches. I am fine either way. Agreed. but it is not normal conding style. comment adding is better, IMHO. at first, I think typo too.