From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759201AbYEHIgw (ORCPT ); Thu, 8 May 2008 04:36:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753382AbYEHIgd (ORCPT ); Thu, 8 May 2008 04:36:33 -0400 Received: from mtagate4.de.ibm.com ([195.212.29.153]:14435 "EHLO mtagate4.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753061AbYEHIgb (ORCPT ); Thu, 8 May 2008 04:36:31 -0400 Date: Thu, 8 May 2008 10:36:21 +0200 From: Cornelia Huck To: benh@kernel.crashing.org Cc: Andrew Morton , David Miller , tony@bakeyournoodle.com, linux-kernel@vger.kernel.org, Greg K-H Subject: Re: [PATCH] Silence 'ignoring return value' warnings in drivers/video/aty/radeon_base.c Message-ID: <20080508103621.69bc47cf@gondolin.boeblingen.de.ibm.com> In-Reply-To: <1210232984.1421.47.camel@pasglop> References: <20080424043400.GS20457@bakeyournoodle.com> <20080506143936.6357e578.akpm@linux-foundation.org> <20080506.144301.233784820.davem@davemloft.net> <1210121683.21644.194.camel@pasglop> <20080506182006.4b4a3968.akpm@linux-foundation.org> <1210134804.21644.202.camel@pasglop> <20080507102310.57b4ccfb@gondolin.boeblingen.de.ibm.com> <1210196621.1421.5.camel@pasglop> <20080508093421.31cd735b@gondolin.boeblingen.de.ibm.com> <1210232984.1421.47.camel@pasglop> Organization: IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Martin Jetter =?ISO-8859-15?Q?Gesch=E4ftsf=FChrung:?= Herbert Kircher Sitz der Gesellschaft: =?ISO-8859-15?Q?B=F6blingen?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.4.0 (GTK+ 2.12.9; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 08 May 2008 17:49:44 +1000, Benjamin Herrenschmidt wrote: > > On Thu, 2008-05-08 at 09:34 +0200, Cornelia Huck wrote: > > > > I was under the impression that failing the initialization was usually > > the right thing to do, since we end up with an un-configurable, > > un-usable device. But that may be coloured by my experience with s390 > > devices, where we rely on sysfs attributes extensively. If indeed most > > sysfs files are non-vital, removing the __must_check and relying on a > > scary warning in the core may be fine. (OTOH, adding checks to the > > core > > has helped us to find some lurking bugs.) > > The driver can still fail initialization if it wants... I'm just > objecting to the __must_check. I hear you :) I found it useful, but it seems we should get rid of it for _create_file() now.