Re: [PATCH] call_usermodehelper_setup() should use GFP_KERNEL

[KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>]

> >> Yeah, but making the caller need to know about the internal 
> >> implementation details of the callee (ie, whether it needs to allocate 
> >> memory or not) leads to pretty warty interfaces.  In this case, you 
> >> could push the gfp_t up to the call_usermodehelper_setup() level, but 
> >> pushing it any higher wouldn't make much sense.
> >
> > No problem :)
> > almost caller doesn't call call_usermodehelper_setup() directly.
> >
> > thus, call_usermodehelper_setup() chage is hided in call_usermodehelper().
> 
> Yep, seems reasonable.  Are there any UMH_NO_WAIT callers who could be 
> using GFP_KERNEL?

UMH_WAIT_EXEC and UMH_WAIT_PROC mean wait on finish of exec or process exit.
I can't imagine situation that exec is waitable *and* allocate isn't waitable.