From: Sebastian Siewior <lkml@ml.breakpoint.cc>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Maciej Sosnowski <maciej.sosnowski@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [ASYNC_TX] don't include <asm/> headers
Date: Sat, 10 May 2008 00:14:41 +0200 [thread overview]
Message-ID: <20080509221441.GA1672@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <e9c3a7c20805091155w741fc8eai761fa232bb27dedf@mail.gmail.com>
* Dan Williams | 2008-05-09 11:55:25 [-0700]:
>On Fri, May 9, 2008 at 1:39 AM, Sebastian Siewior <lkml@ml.breakpoint.cc> wrote:
>> * Dan Williams | 2008-04-29 23:42:46 [-0700]:
>>
>>
>> >Thanks, I'll push this out for testing in -next / -mm.
>> I can't see this in current -next and I can't remember that I got an
>> email from Andrew.
>>
>
>Hi Sebastian,
Hi Dan,
>Yes I had put this in the background for awhile due to other issues.
No problem. If you queue this up for another two weeks than I have no
problem with it. I just wanted to make sure that you did not lose it :)
>I fixed up a few merge conflicts so that it will apply against the
>current tree; however, the patch causes these new warnings:
>
>include/asm/xor_32.h:513: warning: 'xor_block_pII_mmx' defined but not used
>include/asm/xor_32.h:521: warning: 'xor_block_p5_mmx' defined but not used
>include/asm/xor_32.h:853: warning: 'xor_block_pIII_sse' defined but not used
>include/asm-generic/xor.h:680: warning: 'xor_block_8regs' defined but not used
>include/asm-generic/xor.h:688: warning: 'xor_block_32regs' defined but not used
>include/asm-generic/xor.h:696: warning: 'xor_block_8regs_p' defined but not used
>include/asm-generic/xor.h:704: warning: 'xor_block_32regs_p' defined
>but not used
>
>It is not immediately clear why?
I'm not sure why I haven't seen this myself. crypto/xor.c is the only
user of those defines but linux/raid/xor.h is also included by
async_xor.c which does not use xor_block_pII_mmx & friends. The best
thing would be probably _not_ to merge those two header files like I did
but keep them separate. Maybe we could move this define directly into
crypto/xor.c since it is the only user?
Sebastian
prev parent reply other threads:[~2008-05-09 22:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 15:48 Sebastian Siewior
2008-04-30 6:42 ` Dan Williams
2008-05-09 8:39 ` Sebastian Siewior
2008-05-09 18:55 ` Dan Williams
2008-05-09 22:14 ` Sebastian Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080509221441.GA1672@Chamillionaire.breakpoint.cc \
--to=lkml@ml.breakpoint.cc \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.sosnowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®