From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758489AbYEKS66 (ORCPT ); Sun, 11 May 2008 14:58:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755341AbYEKS6u (ORCPT ); Sun, 11 May 2008 14:58:50 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:43325 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754643AbYEKS6t (ORCPT ); Sun, 11 May 2008 14:58:49 -0400 Date: Sun, 11 May 2008 20:54:45 +0200 From: Pavel Machek To: Cyrill Gorcunov Cc: Sam Ravnborg , "H. Peter Anvin" , Mikael Pettersson , "Rafael J. Wysocki" , tglx@linutronix.de, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: 2.6.26-rc1 on x86: ld: warning: dot moved backwards before `.text' Message-ID: <20080511185445.GB5599@elf.ucw.cz> References: <18470.787.498329.144701@harpo.it.uu.se> <482604D1.7020804@zytor.com> <20080510211602.GA32339@uranus.ravnborg.org> <20080511154411.GB6942@cvg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080511154411.GB6942@cvg> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 2008-05-11 19:44:11, Cyrill Gorcunov wrote: > [Sam Ravnborg - Sat, May 10, 2008 at 11:16:02PM +0200] > | On Sat, May 10, 2008 at 01:25:53PM -0700, H. Peter Anvin wrote: > | > Mikael Pettersson wrote: > | > > > | > >The resulting kernel hasn't broken on me yet, however. > | > > > | > >A search through the LKML archives showed that this was reported > | > >for 2.6.25-rc3-mm1, but I couldn't find any discussion about it > | > >after that: > | > > > | > > > | > > > | > >The .config causing this warning is available in > | > > > | > > > | > > | > This is because the organization of the file was changed, and the linker > | > script wasn't changed to match: > | > > | > SECTIONS > | > { > | > . = HEADER_OFFSET; > | > .header : { > | > *(.header) > | > } > | > > | > . = 0; > | > .text : { > | > *(.text*) > | > } > | > > | > This is crap; the sections should be listed *in order* so the linker can > | > warn properly when something bad happens. > | > > | > The code should be correct; reorganizing the linker script correctly > | > should fix the problem. > | > | I need Pavel to comment on this. > | Why we start with . equal 0x3f00 and then later as . equals 0x0000 > | I dunno. > | I did not look into this part of the code back then - but I should anyway > | have seen this flaw in the linker script :-( > | > | Sam > > Should not it be something like > --- > > diff --git a/arch/x86/kernel/acpi/realmode/wakeup.lds.S b/arch/x86/kernel/acpi/realmode/wakeup.lds.S > index 22fab6c..cccf62d 100644 > --- a/arch/x86/kernel/acpi/realmode/wakeup.lds.S > +++ b/arch/x86/kernel/acpi/realmode/wakeup.lds.S > @@ -12,11 +12,6 @@ ENTRY(_start) > > SECTIONS > { > - . = HEADER_OFFSET; > - .header : { > - *(.header) > - } > - > . = 0; > .text : { > *(.text*) > @@ -53,6 +48,11 @@ SECTIONS > . = ALIGN(16); > _end = .; > > + . = HEADER_OFFSET; > + .header : { > + *(.header) > + } > + > /DISCARD/ : { > *(.note*) > } If it passes s2ram/resume test, it is probably correct ;-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html