From: Martin Habets <errandir_news@mph.eclipse.co.uk>
To: David Miller <davem@davemloft.net>
Cc: jlieskov@redhat.com, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: sparc: Fix mremap VA span checking.
Date: Tue, 13 May 2008 00:12:32 +0100 [thread overview]
Message-ID: <20080512231231.GA8373@palantir8> (raw)
In-Reply-To: <20080512.042453.238263459.davem@davemloft.net>
On Mon, May 12, 2008 at 04:24:53AM -0700, David Miller wrote:
> From: Jan Lieskovsky <jlieskov@redhat.com>
> Date: Mon, 12 May 2008 13:15:12 +0200
>
> > I have investigated the code for MREMAP_FIXED in
> > sparc_mremap in arch/sparc/kernel/sys_sparc.c, for sys64_mremap
> > in arch/sparc64/kernel/sys_sparc.c and
> > for sys32_mremap in arch/sparc64/kernel/sys_sparc32.c
> > and there are similar conditional range checks ->
> > attaching the patches against 2.6.25.3.
>
> Thanks for the report, I'll take a look at this after getting
> some sleep as it's late hear.
>
> My first impression is that it might make sense to put an
> arch_mmap_check() call at the appropriate spots instead of duplicating
> this check so many times.
sparc32 already has an sparc_mmap_check() in sys_sparc that does this,
and sparc64 has sparc64_mmap_check().
Calling that should do the trick.
--
Martin
next prev parent reply other threads:[~2008-05-12 23:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 11:15 Jan Lieskovsky
2008-05-12 11:24 ` David Miller
2008-05-12 23:12 ` Martin Habets [this message]
2008-05-12 23:24 ` David Miller
2008-05-12 23:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512231231.GA8373@palantir8 \
--to=errandir_news@mph.eclipse.co.uk \
--cc=davem@davemloft.net \
--cc=jlieskov@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®