From: Randy Dunlap <randy.dunlap@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
muli@il.ibm.com, alexisb@us.ibm.com
Subject: Re: [PATCH 1/2] add the device argument to dma_mapping_error
Date: Tue, 13 May 2008 08:39:01 -0700 [thread overview]
Message-ID: <20080513083901.2f571418.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1210658692-960-2-git-send-email-fujita.tomonori@lab.ntt.co.jp>
On Tue, 13 May 2008 15:04:51 +0900 FUJITA Tomonori wrote:
> dma_mapping_error doesn't take a pointer to the device unlike other
> DMA operations. So we can't have dma_mapping_ops per device.
>
> Note that POWER already has dma_mapping_ops per device but all the
> POWER IOMMUs use the same dma_mapping_error function. x86 IOMMUs use
> different dma_mapping_error functions. So dma_mapping_error needs the
> device argument.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> ---
> arch/arm/common/dmabounce.c | 2 +-
> arch/ia64/hp/common/hwsw_iommu.c | 5 ++-
> arch/ia64/hp/common/sba_iommu.c | 2 +-
> arch/ia64/sn/pci/pci_dma.c | 2 +-
> arch/mips/mm/dma-default.c | 2 +-
> arch/powerpc/platforms/cell/celleb_scc_pciex.c | 2 +-
> arch/powerpc/platforms/cell/spider-pci.c | 2 +-
> arch/powerpc/platforms/iseries/mf.c | 2 +-
> arch/x86/kernel/pci-gart_64.c | 1 -
> arch/x86/kernel/pci-nommu.c | 2 +-
> drivers/firewire/fw-iso.c | 2 +-
> drivers/firewire/fw-ohci.c | 2 +-
> drivers/firewire/fw-sbp2.c | 8 +++---
> drivers/infiniband/hw/ipath/ipath_sdma.c | 2 +-
> drivers/infiniband/hw/ipath/ipath_user_sdma.c | 6 ++--
> drivers/infiniband/hw/mthca/mthca_eq.c | 2 +-
> drivers/media/dvb/pluto2/pluto2.c | 2 +-
> drivers/net/arm/ep93xx_eth.c | 4 +-
> drivers/net/b44.c | 22 +++++++++-------
> drivers/net/bnx2x.c | 2 +-
> drivers/net/e100.c | 2 +-
> drivers/net/e1000e/ethtool.c | 4 +-
> drivers/net/e1000e/netdev.c | 11 ++++---
> drivers/net/ibmveth.c | 32 ++++++++++++-----------
> drivers/net/iseries_veth.c | 4 +-
> drivers/net/mlx4/eq.c | 2 +-
> drivers/net/pasemi_mac.c | 6 ++--
> drivers/net/qla3xxx.c | 12 ++++----
> drivers/net/sfc/rx.c | 4 +-
> drivers/net/sfc/tx.c | 2 +-
> drivers/net/spider_net.c | 4 +-
> drivers/net/tc35815.c | 4 +-
> drivers/net/wireless/ath5k/base.c | 4 +-
> drivers/net/wireless/b43/dma.c | 2 +-
> drivers/net/wireless/b43legacy/dma.c | 2 +-
> drivers/scsi/ibmvscsi/ibmvscsi.c | 4 +-
> drivers/scsi/ibmvscsi/ibmvstgt.c | 2 +-
> drivers/scsi/ibmvscsi/rpa_vscsi.c | 2 +-
> drivers/spi/atmel_spi.c | 4 +-
> drivers/spi/au1550_spi.c | 6 ++--
> drivers/spi/omap2_mcspi.c | 4 +-
> drivers/spi/pxa2xx_spi.c | 4 +-
> drivers/spi/spi_imx.c | 6 ++--
> include/asm-alpha/dma-mapping.h | 6 ++--
> include/asm-alpha/pci.h | 2 +-
> include/asm-arm/dma-mapping.h | 2 +-
> include/asm-avr32/dma-mapping.h | 2 +-
> include/asm-cris/dma-mapping.h | 2 +-
> include/asm-frv/dma-mapping.h | 2 +-
> include/asm-generic/dma-mapping-broken.h | 2 +-
> include/asm-generic/dma-mapping.h | 4 +-
> include/asm-generic/pci-dma-compat.h | 4 +-
> include/asm-ia64/machvec.h | 2 +-
> include/asm-m68k/dma-mapping.h | 2 +-
> include/asm-mips/dma-mapping.h | 2 +-
> include/asm-mn10300/dma-mapping.h | 2 +-
> include/asm-parisc/dma-mapping.h | 2 +-
> include/asm-powerpc/dma-mapping.h | 2 +-
> include/asm-sh/dma-mapping.h | 2 +-
> include/asm-sparc/pci.h | 3 +-
> include/asm-sparc64/dma-mapping.h | 2 +-
> include/asm-sparc64/pci.h | 5 ++-
> include/asm-v850/pci.h | 2 +-
> include/asm-x86/dma-mapping.h | 7 +++--
> include/asm-x86/swiotlb.h | 2 +-
> include/asm-xtensa/dma-mapping.h | 2 +-
> include/linux/i2o.h | 2 +-
> include/rdma/ib_verbs.h | 2 +-
> lib/swiotlb.c | 4 +-
> 69 files changed, 140 insertions(+), 132 deletions(-)
Seems to be missing updates to Documentation/DMA-API.txt ??
---
~Randy
next prev parent reply other threads:[~2008-05-13 15:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 6:04 [PATCH 0/2] x86: per-device dma_mapping_ops FUJITA Tomonori
2008-05-13 6:04 ` [PATCH 1/2] add the device argument to dma_mapping_error FUJITA Tomonori
2008-05-13 6:04 ` [PATCH 2/2] x86: per-device dma_mapping_ops support FUJITA Tomonori
2008-05-14 5:55 ` Muli Ben-Yehuda
2008-05-15 20:45 ` Yinghai Lu
2008-05-16 3:44 ` FUJITA Tomonori
2008-05-13 15:39 ` Randy Dunlap [this message]
2008-05-15 1:12 ` [PATCH 1/2] add the device argument to dma_mapping_error FUJITA Tomonori
2008-05-14 5:49 ` [PATCH 0/2] x86: per-device dma_mapping_ops Muli Ben-Yehuda
2008-05-15 1:12 ` FUJITA Tomonori
2008-05-15 2:00 ` Alexis Bruemmer
2008-05-15 2:30 ` FUJITA Tomonori
2008-05-15 18:21 ` Alexis Bruemmer
2008-05-15 15:17 ` Muli Ben-Yehuda
2008-05-15 15:15 ` Muli Ben-Yehuda
2008-05-15 9:01 ` Andi Kleen
2008-05-15 9:16 ` FUJITA Tomonori
2008-05-15 9:30 ` Andi Kleen
2008-05-15 9:41 ` FUJITA Tomonori
2008-05-15 10:48 ` Andi Kleen
2008-05-15 15:32 ` Muli Ben-Yehuda
2008-05-16 3:44 ` FUJITA Tomonori
2008-05-16 5:24 ` Andi Kleen
2008-05-19 6:32 ` FUJITA Tomonori
2008-05-15 15:26 ` Muli Ben-Yehuda
2008-05-15 21:03 ` Andi Kleen
2008-05-15 21:39 ` Muli Ben-Yehuda
2008-05-15 21:45 ` Andi Kleen
2008-05-15 21:53 ` Muli Ben-Yehuda
2008-05-15 22:05 ` Muli Ben-Yehuda
2008-05-15 18:25 ` Alexis Bruemmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513083901.2f571418.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=alexisb@us.ibm.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®