From: Ingo Molnar <mingo@elte.hu>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: Remove unused variable "cpu" from arch/x86/xen/setup.c
Date: Tue, 13 May 2008 14:07:07 +0200 [thread overview]
Message-ID: <20080513120707.GE32022@elte.hu> (raw)
In-Reply-To: <ea11fea30805111026o448f5711nc6db445db0995b5c@mail.gmail.com>
* Manish Katiyar <mkatiyar@gmail.com> wrote:
> Remove unused variable "cpu" from arch/x86/xen/setup.c
it's not unused:
> void xen_enable_sysenter(void)
> {
> - int cpu = smp_processor_id();
> extern void xen_sysenter_target(void);
> /* Mask events on entry, even though they get enabled immediately */
> static struct callback_register sysenter = {
if (!boot_cpu_has(X86_FEATURE_SEP) ||
HYPERVISOR_callback_op(CALLBACKOP_register, &sysenter) != 0) {
clear_cpu_cap(&cpu_data(cpu), X86_FEATURE_SEP);
^^^^^^^^^^^^^^
clear_cpu_cap(&boot_cpu_data, X86_FEATURE_SEP);
}
if it generates an unused variable warning on UP then per_cpu() needs to
be fixed to do a (void)(cpu) to indicate use of that variable.
Ingo
prev parent reply other threads:[~2008-05-13 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-11 17:26 Manish Katiyar
2008-05-13 12:07 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513120707.GE32022@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkatiyar@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®