From: Andres Salomon <dilinger@queued.net>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
mingo@elte.hu, rdunlap@xenotime.net, jschopp@austin.ibm.com
Subject: Re: [PATCH] checkpatch: update the 80-char-line check to allow for long strings
Date: Wed, 14 May 2008 12:23:19 -0400 [thread overview]
Message-ID: <20080514122319.054d9aaa@ephemeral> (raw)
In-Reply-To: <20080514155926.GF2821@shadowen.org>
On Wed, 14 May 2008 16:59:26 +0100
Andy Whitcroft <apw@shadowen.org> wrote:
> On Wed, May 14, 2008 at 10:49:38AM -0400, Andres Salomon wrote:
> > On Wed, 14 May 2008 09:49:06 +0200
> > Peter Zijlstra <peterz@infradead.org> wrote:
> >
[...]
> >
> > The point is that we tell people to make sure that their patches are
> > checkpatch-clean. Let's make the tool reflect what we're actually
> > looking for.
>
> We did have a mini discussion on this when Ingo suggested allowing the
> strings to run off the end of the line so that grep would work. I did
> put together a patch then for this. There was no real response to the
> suggestion we should take that recommendation into CodingStyle and
> thus into checkpatch.
>
> -apw
I've yet to hear anyone say that this idea is awful...
prev parent reply other threads:[~2008-05-14 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 4:53 Andres Salomon
2008-05-14 7:49 ` Peter Zijlstra
2008-05-14 14:49 ` Andres Salomon
2008-05-14 15:59 ` Andy Whitcroft
2008-05-14 16:23 ` Andres Salomon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080514122319.054d9aaa@ephemeral \
--to=dilinger@queued.net \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®