From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: rtc-linux@googlegroups.com
Cc: Kim.Heino@bluegiga.com, linux-kernel@vger.kernel.org
Subject: Re: [rtc-linux] Re: [PATCH] add support for ST M41T94 SPI RTC
Date: Wed, 14 May 2008 20:53:08 +0200 [thread overview]
Message-ID: <20080514205308.63951ad0@i1501.lan.towertech.it> (raw)
In-Reply-To: <482AF5E7.9070801@bluegiga.com>
On Wed, 14 May 2008 17:23:35 +0300
"Kim B. Heino" <Kim.Heino@bluegiga.com> wrote:
>
>
> >> +struct m41t94 {
> >> + struct rtc_device *rtc;
> >> + u8 buf[8]; /* Burst read cmd + 7 registers */
> >> +};
> > why are you keeping the buffer here?
>
> rtc-max6902.c did that too... Fixed.
d'oh! I missed it. :)
> > the choice is up to you, but I'd use the century bit if there
> > is one.
>
> Ok, I'll add support for century bit. Again there are some other
> rtc-drivers (like rtc-m41t80.c and rtc-ds1307.c) not using it.
it's not mandatory, just a suggestion.
>
> I'll wait for more comments and post a new patch tomorrow.
ok, thanks.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
prev parent reply other threads:[~2008-05-14 18:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 12:19 Kim B. Heino
2008-05-14 13:08 ` [rtc-linux] " Alessandro Zummo
2008-05-14 14:23 ` [rtc-linux] " Kim B. Heino
2008-05-14 16:37 ` Maciej W. Rozycki
2008-05-14 18:53 ` Alessandro Zummo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080514205308.63951ad0@i1501.lan.towertech.it \
--to=alessandro.zummo@towertech.it \
--cc=Kim.Heino@bluegiga.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®