mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: rtc-linux@googlegroups.com
Cc: Kim.Heino@bluegiga.com, linux-kernel@vger.kernel.org
Subject: Re: [rtc-linux] [PATCH] add support for ST M41T94 SPI RTC (patch rev. 2)
Date: Thu, 15 May 2008 12:13:12 +0200	[thread overview]
Message-ID: <20080515121312.4af159d9@i1501.lan.towertech.it> (raw)
In-Reply-To: <482C0801.7030007@bluegiga.com>

On Thu, 15 May 2008 12:53:05 +0300
"Kim B. Heino" <Kim.Heino@bluegiga.com> wrote:

> 
> +struct m41t94 {
> +	struct rtc_device *rtc;
> +};

 [...]


> +
> +static int __devinit m41t94_probe(struct spi_device *spi)
> +{
> +	struct rtc_device *rtc;
> +	struct m41t94 *m41t94;
> +	int res;
> +
> +	m41t94 = kzalloc(sizeof(struct m41t94), GFP_KERNEL);
> +	if (!m41t94)
> +		return -ENOMEM;
> +	dev_set_drvdata(&spi->dev, m41t94);

 [..]

> +	rtc = rtc_device_register(m41t94_driver.driver.name,
> +		&spi->dev, &m41t94_rtc_ops, THIS_MODULE);
> +	if (IS_ERR(rtc)) {
> +		kfree(m41t94);
> +		return PTR_ERR(rtc);
> +	}
> +
> +	m41t94->rtc = rtc;
> +
> +	return 0;
> +}
>

 thanks for having implemented the sugestions.

 one more thing. now that the struct m41t94 is
 almost empty it makes no sense to keep it.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it


      reply	other threads:[~2008-05-15 10:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15  9:53 Kim B. Heino
2008-05-15 10:13 ` Alessandro Zummo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080515121312.4af159d9@i1501.lan.towertech.it \
    --to=alessandro.zummo@towertech.it \
    --cc=Kim.Heino@bluegiga.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome