Re: [GIT PATCHES] V4L/DVB fixes for 2.6.26

[Mauro Carvalho Chehab <mchehab@infradead.org>]

On Thu, 15 May 2008 19:02:46 +0300
Adrian Bunk <bunk@kernel.org> wrote:

> On Wed, May 14, 2008 at 05:04:05PM -0300, Mauro Carvalho Chehab wrote:
> >...
> > > but otherwise that 
> > > would be a straightforward solution to solve these problems.
> > 
> > This will solve several troubles. Still, I think that there are still some
> > other missing dependencies (like INPUT, on drivers that select IR).
> 
> We could select INPUT from drivers/media/

Several drivers don't need INPUT (webcams, radio, etc). This is needed only by
the TV reception devices (analog and digital). 

Yet, I can't imagine any production kernel without INPUT. What happens if INPUT
is disabled? No keyboard, no tablet and no mouse at all?

> And FW_LOADER should really select HOTPLUG - there's no good reason for 
> FW_LOADER to be a user-visible option with dependencies.

It seems safe to select HOTPLUG instead of depending on it.

> But these two are problems that are only relevant for randconfig users 

True. Hotplug may eventually be relevant for embedded users. However,
"depends on HOTPLUG" is already present to all points where FW_LOADER is
needed (I added such patch at my previous pull request). So, the way it is
seems OK. I don't see much reason to change it.

> while the I2C troubles hit real users, so I want to attack the I2C 
> issues first.

Very true. Also, it is not obvious to the final user that he would need to
select I2C to have a video input driver.

> > > Any problem I miss or should I bake a patch?
> > 
> > I can't see any trouble on this approach. Feel free to work on it.
> 
> First issue when working on it:
> 
> The dependencies between VIDEO_IR and VIDEO_IR_I2C look wrong
> (consider VIDEO_IR=y and I2C=m).
> 
> It's not a problem since currently all users of VIDEO_IR also depend
> on I2C.

True. I got a compilation error with saa7134 that seems to be caused by this
trouble.
> 
> Should I fix the dependency or can I let VIDEO_IR select I2C and remove 
> VIDEO_IR_I2C?

The better would be to fix the dependency. The proper way seems to remove the
select from VIDEO_IR, and add an explicit select to VIDEO_IR_I2C where needed.

I would add an entry to allow the user to select this explicitly, for power
users, and select it implicitly. Something like:

select VIDEO_IR_I2C  if VIDEO_HELPER_CHIPS_AUTO

at the drivers under media/video that selects IR. This need to be mandatory for
a few drivers like saa7134, where some exported symbols at kbd-ir-i2c are used
there.

Cheers,
Mauro