From: Sam Ravnborg <sam@ravnborg.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: "Toralf Förster" <toralf.foerster@gmx.de>,
"Mauro Carvalho Chehab" <mchehab@infradead.org>,
linux-kernel@vger.kernel.org, video4linux-list@redhat.com
Subject: Re: [2.6 patch] always enter drivers/media/video/
Date: Fri, 16 May 2008 11:25:43 +0200 [thread overview]
Message-ID: <20080516092543.GB31432@uranus.ravnborg.org> (raw)
In-Reply-To: <20080516080113.GO1936@cs181133002.pp.htv.fi>
On Fri, May 16, 2008 at 11:01:13AM +0300, Adrian Bunk wrote:
> After commit 039d40019f3c5e26ea50ec5af4270189f63365e1
> (V4L/DVB (7898): Fix VIDEO_MEDIA Kconfig logic)
> VIDEO_MEDIA is no longer usable in Makefile's for deciding
> which directories we enter, resulting in compile errors like the
> following with CONFIG_VIDEO_DEV=y, CONFIG_DVB_CORE=m:
>
> <-- snip -->
>
> ...
> MODPOST 187 modules
> ERROR: "video_exclusive_release" [drivers/media/radio/radio-zoltrix.ko] undefined!
> ERROR: "video_exclusive_open" [drivers/media/radio/radio-zoltrix.ko] undefined!
> ERROR: "video_ioctl2" [drivers/media/radio/radio-zoltrix.ko] undefined!
> ERROR: "video_register_device" [drivers/media/radio/radio-zoltrix.ko] undefined!
> ERROR: "video_devdata" [drivers/media/radio/radio-zoltrix.ko] undefined!
> ERROR: "video_unregister_device" [drivers/media/radio/radio-zoltrix.ko] undefined!
> ...
> make[2]: *** [__modpost] Error 1
>
> <-- snip -->
>
> The easiest solution is to always enter video/
>
> Reported-by: Toralf Förster <toralf.foerster@gmx.de>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> 62aa0f0990ec569868b34764c255268a5e425486 diff --git a/drivers/media/Makefile b/drivers/media/Makefile
> index cc11c4c..09a829d 100644
> --- a/drivers/media/Makefile
> +++ b/drivers/media/Makefile
> @@ -2,12 +2,7 @@
> # Makefile for the kernel multimedia device drivers.
> #
>
> -obj-y := common/
> -
> -obj-$(CONFIG_VIDEO_MEDIA) += common/
> -
> -# Since hybrid devices are here, should be compiled if DVB and/or V4L
> -obj-$(CONFIG_VIDEO_MEDIA) += video/
> +obj-y += common/ video/
>
> obj-$(CONFIG_VIDEO_DEV) += radio/
> obj-$(CONFIG_DVB_CORE) += dvb/
Looks good. We end up with a simpler Makefile.
Sam
prev parent reply other threads:[~2008-05-16 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 13:15 build issue #502 for v2.6.26-rc2-372-g8f40f67 : video_exclusive_release undefined! Toralf Förster
2008-05-16 8:01 ` [2.6 patch] always enter drivers/media/video/ Adrian Bunk
2008-05-16 9:25 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080516092543.GB31432@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=toralf.foerster@gmx.de \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®