From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756115AbYEPLUQ (ORCPT ); Fri, 16 May 2008 07:20:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752888AbYEPLUF (ORCPT ); Fri, 16 May 2008 07:20:05 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:33195 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752846AbYEPLUE (ORCPT ); Fri, 16 May 2008 07:20:04 -0400 Date: Fri, 16 May 2008 13:19:48 +0200 From: Ingo Molnar To: Sam Ravnborg Cc: Mauro Carvalho Chehab , linux-kernel@vger.kernel.org Subject: Re: [patch] drivers/media/video build fix for certain modular builds Message-ID: <20080516111948.GA4847@elte.hu> References: <20080516071029.GA13147@elte.hu> <20080516092440.GA31432@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080516092440.GA31432@uranus.ravnborg.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Sam Ravnborg wrote: > On Fri, May 16, 2008 at 09:10:29AM +0200, Ingo Molnar wrote: > > > > testing of the -tip tree found the following missing symbols build bug: > > > > LD init/built-in.o > > LD .tmp_vmlinux1 > > drivers/built-in.o: In function `vidioc_g_ctrl': > > radio-maxiradio.c:(.text+0xd3337): undefined reference to `video_devdata' > > drivers/built-in.o: In function `vidioc_g_frequency': > > radio-maxiradio.c:(.text+0xd3368): undefined reference to `video_devdata' > > drivers/built-in.o: In function `vidioc_s_ctrl': > > [...] > > > > which happens if certain media drivers are modular: > > > > http://redhat.com/~mingo/misc/config-Thu_May_15_18_10_27_CEST_2008.bad > > > > the problem is: > > > > CONFIG_VIDEO_MEDIA=m > > CONFIG_VIDEO_DEV=y > > CONFIG_RADIO_MAXIRADIO=y > > CONFIG_VIDEO_V4L2=y > > > > Connecting the build dependencies tree from drivers/media/ to > > drivers/media/video/ allows the built-in drivers(s) to pick up the > > CONFIG_VIDEO_DEV=y symbols. > > > > --- > > drivers/media/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Index: linux/drivers/media/Makefile > > =================================================================== > > --- linux.orig/drivers/media/Makefile > > +++ linux/drivers/media/Makefile > > @@ -2,7 +2,7 @@ > > # Makefile for the kernel multimedia device drivers. > > # > > > > -obj-y := common/ > > +obj-y := common/ video/ > > > > obj-$(CONFIG_VIDEO_MEDIA) += common/ > > > > Adrian just posted a similar fix that I like better because it > cleans up the Makefile a bit. > The obj-$(CONFIG_VIDEO_MEDIA) += common/ assignment in the > above is for example now redundant. > > But otherwise obviously correct. sure enough, i went for the minimal fix. Adrian's patch looks good too. Acked-by: Ingo Molnar Ingo