From: "Christophe Jaillet" <christophe.jaillet@wanadoo.fr>
To: "cj" <christophe.jaillet@wanadoo.fr>,
"linux" <linux-kernel@vger.kernel.org>, <zippel@linux-m68k.org>,
<linux-kbuild@vger.kernel.org>
Subject: [PATCH 1/1] kconfig: incorrect 'len' field initialisation ?
Date: Sun, 18 May 2008 23:10:24 +0200 [thread overview]
Message-ID: <20080518211024.D1B751C00086@mwinf2714.orange.fr> (raw)
From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Hi, here is a patch against /scripts/kconfig/util.c :
1) The field 'len' of the 'gstr' structure seems to track the size of the memory
already allocated for the "growable string". So the value of this field should be
the same as the 'malloc()' just above, shouldn't it ?
Note: this patch is based on 'linux-2.6.25.tar.bz2'
Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
---
--- linux 2.6.25/scripts/kconfig/util.c 2008-04-17 04:49:44.000000000 +0200
+++ linux 2.6.25/scripts/kconfig/util.c.cj 2008-05-18 22:56:14.000000000 +0200
@@ -77,7 +77,7 @@ struct gstr str_new(void)
{
struct gstr gs;
gs.s = malloc(sizeof(char) * 64);
- gs.len = 16;
+ gs.len = 64;
strcpy(gs.s, "\0");
return gs;
}
next reply other threads:[~2008-05-18 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 21:10 Christophe Jaillet [this message]
2008-05-19 6:39 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080518211024.D1B751C00086@mwinf2714.orange.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®