From: Christoph Hellwig <hch@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Trond.Myklebust@netapp.com, swhiteho@redhat.com,
sfrench@samba.org, vandrove@vc.cvut.cz, corbet@lwn.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [1/11] Remove BKL from remote_llseek
Date: Mon, 19 May 2008 10:02:35 -0400 [thread overview]
Message-ID: <20080519140235.GA24267@infradead.org> (raw)
In-Reply-To: <20080519123110.930491B41FF@basil.firstfloor.org>
On Mon, May 19, 2008 at 02:31:10PM +0200, Andi Kleen wrote:
>
> - Replace remote_llseek with remote_llseek_unlocked (to force compilation
> failures in all users)
> - Change all users to either use remote_llseek directly or take the
> BKL around. I changed the file systems who don't use the BKL
> for anything (CIFS, GFS) to call it directly. NCPFS and SMBFS and NFS
> take the BKL, but explicitely in their own source now.
>
> I moved them all over in a single patch to avoid unbisectable sections.
Good idea, but it could be done a little bit nicer still.
Your new remote_llseek_unlocked is the same as generic_file_llseek
except for the fact that it doesn't take i_mutex. So I'd rather
call it generic_file_llseek_nolock and make generic_file_llseek call
it. While you're at it you could also add some kerneldoc documents
describing them.
next prev parent reply other threads:[~2008-05-19 14:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 12:31 [PATCH] [0/11] Repost of old VFS BKL patchkit Andi Kleen
2008-05-19 12:31 ` [PATCH] [1/11] Remove BKL from remote_llseek Andi Kleen
2008-05-19 13:58 ` Trond Myklebust
2008-05-19 14:41 ` Andi Kleen
2008-05-19 14:02 ` Christoph Hellwig [this message]
2008-05-19 15:13 ` Andi Kleen
2008-05-19 16:09 ` Steve French
2008-05-19 12:31 ` [PATCH] [2/11] Add unlocked_fasync Andi Kleen
2008-05-19 14:03 ` Christoph Hellwig
2008-05-19 14:43 ` Andi Kleen
2008-05-19 15:12 ` Alan Cox
2008-05-19 15:29 ` Andi Kleen
2008-05-19 15:22 ` Alan Cox
2008-05-19 15:45 ` Andi Kleen
2008-05-19 17:29 ` Randy Dunlap
2008-05-19 12:31 ` [PATCH] [3/11] Convert pipe over to unlocked_fasync Andi Kleen
2008-05-19 12:31 ` [PATCH] [4/11] Convert socket fasync " Andi Kleen
2008-05-19 12:31 ` [PATCH] [5/11] Convert fuse " Andi Kleen
2008-05-19 12:31 ` [PATCH] [6/11] Convert bad_inode " Andi Kleen
2008-05-19 12:31 ` [PATCH] [7/11] Convert DRM " Andi Kleen
2008-05-19 12:31 ` [PATCH] [8/11] Use unlocked_fasync in random.c Andi Kleen
2008-05-19 12:31 ` [PATCH] [9/11] Convert hpet to unlocked_fasync Andi Kleen
2008-05-19 12:31 ` [PATCH] [10/11] Use unlocked_fasync in RTC Andi Kleen
2008-05-19 12:31 ` [PATCH] [11/11] Convert uio to fasync_unlocked Andi Kleen
2008-05-19 12:48 ` Andi Kleen
2008-05-19 13:30 ` Hans J. Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080519140235.GA24267@infradead.org \
--to=hch@infradead.org \
--cc=Trond.Myklebust@netapp.com \
--cc=andi@firstfloor.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=swhiteho@redhat.com \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®