From: Ingo Molnar <mingo@elte.hu>
To: Paul Jackson <pj@sgi.com>
Cc: ying.huang@intel.com, hpa@zytor.com, andi@firstfloor.org,
akpm@linux-foundation.org, tglx@linutronix.de, steiner@sgi.com,
travis@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] x86 boot: add code to add BIOS provided EFI memory entries to kernel
Date: Mon, 19 May 2008 18:10:20 +0200 [thread overview]
Message-ID: <20080519161020.GB16164@elte.hu> (raw)
In-Reply-To: <20080518014926.917ca9a7.pj@sgi.com>
* Paul Jackson <pj@sgi.com> wrote:
> Ingo wrote:
> > so double-checking [the merge of my x86 boot patches] would be nice.
>
> I only see one detail worth mentioning on reading the resulting merge
> in ingo.tip.
>
> Shouldn't the static array declarations in arch/x86/kernel/e820.c be
> indented? It looks like the -file- static declarations from
> arch/x86/kernel/e820_32.c (which were not indented) took precedence in
> the merge over the -function- static declarations from
> arch/x86/kernel/e820_64.c. The code, from the perspective of what
> ends up in the compiled kernel, seems fine -- just the indentation
> off.
>
> int __init sanitize_e820_map(struct e820entry *biosmap, int max_nr_map,
> int *pnr_map)
> {
> struct change_member {
> struct e820entry *pbios; /* pointer to original bios entry */
> unsigned long long addr; /* address for this change point */
> };
> static struct change_member change_point_list[2*E820_X_MAX] __initdata;
> static struct change_member *change_point[2*E820_X_MAX] __initdata;
> static struct e820entry *overlap_list[E820_X_MAX] __initdata;
> static struct e820entry new_bios[E820_X_MAX] __initdata;
> struct change_member *change_tmp;
> unsigned long current_type, last_type;
> unsigned long long last_addr;
indeed that's quite off.
Ingo
next prev parent reply other threads:[~2008-05-19 16:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 15:15 [PATCH 1/10] x86 boot: include missing smp.h header Paul Jackson
2008-05-14 15:15 ` [PATCH 2/10] x86 boot: remove some unused extern function declarations Paul Jackson
2008-05-14 15:15 ` [PATCH 3/10] x86 boot: add header comment to dmi.h stating what it is Paul Jackson
2008-05-14 15:15 ` [PATCH 4/10] x86 boot: simplify pageblock_bits enum declaration Paul Jackson
2008-05-14 15:15 ` [PATCH 5/10] x86 boot: minor code format fixes in e820 and efi routines Paul Jackson
2008-05-14 15:15 ` [PATCH 6/10] x86 boot: proper use of ARRAY_SIZE instead of repeated E820MAX constant Paul Jackson
2008-05-14 15:15 ` [PATCH 7/10] x86 boot: extend some internal memory map arrays to handle larger EFI input Paul Jackson
2008-05-14 15:15 ` [PATCH 8/10] x86 boot: change sanitize_e820_map parameter from byte to int to allow bigger memory maps Paul Jackson
2008-05-14 15:15 ` [PATCH 9/10] x86 boot: longer comment explaining sanitize_e820_map routine Paul Jackson
2008-05-14 15:15 ` [PATCH 10/10] x86 boot: add code to add BIOS provided EFI memory entries to kernel Paul Jackson
2008-05-16 0:03 ` Paul Jackson
2008-05-16 12:38 ` Ingo Molnar
2008-05-16 16:30 ` Paul Jackson
2008-05-18 6:49 ` Paul Jackson
2008-05-19 16:10 ` Ingo Molnar [this message]
2008-05-27 3:12 ` Huang, Ying
2008-05-27 19:08 ` Paul Jackson
2008-05-27 19:16 ` H. Peter Anvin
2008-05-28 9:59 ` Paul Jackson
2008-05-16 13:20 ` [PATCH 1/10] x86 boot: include missing smp.h header Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080519161020.GB16164@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®