From: Andrew Morton <akpm@linux-foundation.org>
To: Matthias Kaehlcke <matthias@kaehlcke.net>
Cc: ecashin@coraid.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ATA over Ethernet: Convert emsgs_sema in a completion
Date: Mon, 19 May 2008 16:51:22 -0700 [thread overview]
Message-ID: <20080519165122.9d94cc1c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080516191133.GI24569@traven>
On Fri, 16 May 2008 21:11:33 +0200
Matthias Kaehlcke <matthias@kaehlcke.net> wrote:
> @@ -216,7 +217,7 @@ aoechr_read(struct file *filp, char __user *buf, size_t cnt, loff_t *off)
>
> spin_unlock_irqrestore(&emsgs_lock, flags);
>
> - n = down_interruptible(&emsgs_sema);
> + n = wait_for_completion_interruptible(&emsgs_comp);
Patch looks OK, but I worry about this code. Suppose a signal is sent
and we return to userspace with the complete() still outstanding. Then
someone removes the module.
Perhaps there is synchronisation code which prevents that crash?
next prev parent reply other threads:[~2008-05-19 23:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 19:11 Matthias Kaehlcke
2008-05-19 23:51 ` Andrew Morton [this message]
2008-05-21 14:49 ` Ed L. Cashin
2008-05-21 18:38 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080519165122.9d94cc1c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ecashin@coraid.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias@kaehlcke.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®