From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762743AbYESRrQ (ORCPT ); Mon, 19 May 2008 13:47:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758080AbYESRrD (ORCPT ); Mon, 19 May 2008 13:47:03 -0400 Received: from pasmtpa.tele.dk ([80.160.77.114]:39958 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756215AbYESRrC (ORCPT ); Mon, 19 May 2008 13:47:02 -0400 Date: Mon, 19 May 2008 19:47:39 +0200 From: Sam Ravnborg To: Alan Cox Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, greg@kroah.com Subject: Re: [PATCH 01/20] tty: Introduce a tty_port common structure Message-ID: <20080519174738.GA20961@uranus.ravnborg.org> References: <20080519144557.19326.74313.stgit@core> <20080519145013.19326.38344.stgit@core> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080519145013.19326.38344.stgit@core> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alan. On Mon, May 19, 2008 at 03:50:13PM +0100, Alan Cox wrote: > From: Alan Cox > > Every tty driver has its own concept of a port structure and because they all > differ we cannot extract commonality. Begin fixing this by creating a structure > drivers can elect to use so that over time we can push fields into this and > create commonality and then introduce common methods. > --- > > drivers/char/tty_io.c | 37 +++++++++++++++++++++++++++++++++++++ > include/linux/tty.h | 29 +++++++++++++++++++++++++++++ > 2 files changed, 66 insertions(+), 0 deletions(-) > > > diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c > index 49c1a22..fb17b18 100644 > --- a/drivers/char/tty_io.c > +++ b/drivers/char/tty_io.c > @@ -2004,6 +2004,43 @@ ssize_t redirected_tty_write(struct file *file, const char __user *buf, > return tty_write(file, buf, count, ppos); > } > > +void tty_port_init(struct tty_port *port) > +{ > + memset(port, 0, sizeof(*port)); > + init_waitqueue_head(&port->open_wait); > + init_waitqueue_head(&port->close_wait); > + mutex_init(&port->mutex); > +} > + > +EXPORT_SYMBOL(tty_port_init); A small nitpick... The typical style is to let the EXPORT_SYMBOL follow the closing brace with no extra empty line. Sam