From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756996AbYETChl (ORCPT ); Mon, 19 May 2008 22:37:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756602AbYETChc (ORCPT ); Mon, 19 May 2008 22:37:32 -0400 Received: from BISCAYNE-ONE-STATION.MIT.EDU ([18.7.7.80]:62243 "EHLO biscayne-one-station.mit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756595AbYETChb (ORCPT ); Mon, 19 May 2008 22:37:31 -0400 Date: Mon, 19 May 2008 22:34:55 -0400 From: Theodore Tso To: Eric Sandeen Cc: ext4 development , linux-kernel Mailing List , linux-fsdevel , Andrew Morton , Jamie Lokier Subject: Re: [PATCH 4/4] ext4: call blkdev_issue_flush on fsync Message-ID: <20080520023454.GM15035@mit.edu> Mail-Followup-To: Theodore Tso , Eric Sandeen , ext4 development , linux-kernel Mailing List , linux-fsdevel , Andrew Morton , Jamie Lokier References: <482DDA56.6000301@redhat.com> <482DDC04.7020706@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <482DDC04.7020706@redhat.com> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) X-Spam-Flag: NO X-Spam-Score: 0.00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 16, 2008 at 02:09:56PM -0500, Eric Sandeen wrote: > To ensure that bits are truly on-disk after an fsync, > we should call blkdev_issue_flush if barriers are supported. This patch isn't necessary, and in fact will cause a double flush. When you call fsync(), it calls ext4_force_commit(), and we do a the equivalent of a blkdev_issue_flush() today (which is what happenes when you do a submit_bh(WRITE_BARRIER, bh), which is what setting set_ordered_mode(bh) ends up causing. - Ted