From: Dave Jones <davej@redhat.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
hpa@zytor.com
Subject: [X86] Remove unnecessary code in 64bit CPU identification.
Date: Tue, 20 May 2008 00:09:35 -0400 [thread overview]
Message-ID: <200805200409.m4K49ZuE024343@gelk.kernelslacker.org> (raw)
There were no 64bit Transmeta CPUs made (and it'd be something of
a surprise if they started any time soon). To the best of my knowledge,
no CPU vendor cloned the 80860000 cpuid space claimed by Transmeta.
By removing this code, we can also eliminate calling cpuid 0x80000007 twice.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/arch/x86/kernel/setup_64.c b/arch/x86/kernel/setup_64.c
index ff62838..0380726 100644
--- a/arch/x86/kernel/setup_64.c
+++ b/arch/x86/kernel/setup_64.c
@@ -1042,20 +1042,11 @@ static void __cpuinit early_identify_cpu(struct cpuinfo_x86 *c)
}
if (xlvl >= 0x80000004)
get_model_name(c); /* Default name */
- }
- /* Transmeta-defined flags: level 0x80860001 */
- xlvl = cpuid_eax(0x80860000);
- if ((xlvl & 0xffff0000) == 0x80860000) {
- /* Don't set x86_cpuid_level here for now to not confuse. */
- if (xlvl >= 0x80860001)
- c->x86_capability[2] = cpuid_edx(0x80860001);
+ if (xlvl >= 0x80000007)
+ c->x86_power = cpuid_edx(0x80000007);
}
- c->extended_cpuid_level = cpuid_eax(0x80000000);
- if (c->extended_cpuid_level >= 0x80000007)
- c->x86_power = cpuid_edx(0x80000007);
-
switch (c->x86_vendor) {
case X86_VENDOR_AMD:
early_init_amd(c);
next reply other threads:[~2008-05-20 4:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 4:09 Dave Jones [this message]
2008-05-20 4:14 ` Dave Jones
2008-05-20 14:46 ` H. Peter Anvin
2008-05-20 15:16 ` Dave Jones
2008-05-20 17:58 ` H. Peter Anvin
2008-05-20 18:06 ` Dave Jones
2008-05-20 19:18 ` Dave Jones
2008-05-20 19:42 ` H. Peter Anvin
2008-05-21 23:55 ` H. Peter Anvin
2008-05-22 14:04 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805200409.m4K49ZuE024343@gelk.kernelslacker.org \
--to=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®