From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933098AbYETUQr (ORCPT ); Tue, 20 May 2008 16:16:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759627AbYETUQj (ORCPT ); Tue, 20 May 2008 16:16:39 -0400 Received: from outbound-mail-129.bluehost.com ([67.222.38.29]:43570 "HELO outbound-mail-129.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1758843AbYETUQj (ORCPT ); Tue, 20 May 2008 16:16:39 -0400 From: Jesse Barnes To: Gary Hade Subject: Re: [PATCH] PCI: boot parameter to avoid expansion ROM memory allocation Date: Tue, 20 May 2008 13:16:33 -0700 User-Agent: KMail/1.9.9 Cc: Yinghai Lu , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20080512205746.GB7401@us.ibm.com> <200805201057.49679.jbarnes@virtuousgeek.org> <20080520200049.GA7334@us.ibm.com> In-Reply-To: <20080520200049.GA7334@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805201316.33882.jbarnes@virtuousgeek.org> X-Identified-User: {642:box128.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 75.111.27.49 authed with jbarnes@virtuousgeek.org} DomainKey-Status: no signature Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, May 20, 2008 1:00 pm Gary Hade wrote: > On Tue, May 20, 2008 at 10:57:49AM -0700, Jesse Barnes wrote: > > On Wednesday, May 14, 2008 9:20 am Gary Hade wrote: > > > > Correct, not a perfect solution but better than we have right now. > > > > > > ...but don't let this comment make you think that I am not in > > > favor of something like you are suggesting. I am interested > > > in getting the 'pci=norom' change into mainline quickly but it > > > is obviously less than ideal for the long term. > > > > > > Jesse, any idea how many different devices absolutely need > > > memory allocated for their expansion ROMs? > > > > Unless there's a ton of demand, I'd rather go with the norom option, but > > either way, I'd like to push the fix early in the 2.6.27 cycle rather > > than trying to get it into 2.6.26 at the last minute... > > This is fine. I would also like to see the pci=norom option > added as-is with the thought that we may improve later by either > modifying pci=norom to exclude devices that need memory mapped > to their expansion ROMs or by adding another option (pci=minrom ?) > that would do the same thing. > > > So assuming you're ok with your last patch, I'll stuff it into > > linux-next. > > Works for me. Thanks. Ok, just pushed the norom patch to linux-next. I'll test it out, but it would be good if you could try the tree out out on one of the problem machines too. Thanks, Jesse